Skip to content

Add decoder unit tests - #907

Merged
jonathanp-okta merged 4 commits into
masterfrom
add-decoder-unit-tests
Aug 25, 2026
Merged

jonathanp-okta merged 4 commits into
masterfrom
add-decoder-unit-tests

Conversation

@christiansamaniego-okta

Copy link
Copy Markdown
Contributor

No description provided.

@github-actions

github-actions Bot commented Nov 5, 2025

Copy link
Copy Markdown

@jonathanp-okta

jonathanp-okta commented Aug 25, 2026 •

Copy link
Copy Markdown
Contributor

Assessment of #907:

  • Test-only PR, no risk to production code.Verified locally: all 6 tests pass against current master.
  • Fills a real gap — decoder service had zero unit tests before this.
  • Caveat: coverage is partial — it exercises the "empty token," "invalid format," "unsecured JWT," and HMAC valid/invalid paths, but not the digital-signature (RS/ES) branch or the public-key-download-failure paths in handleJwtChange. Not a blocker, just worth a review comment.
  • It's "Awaiting approval" with no reviews yet — that's the only thing blocking merge, not code quality.

@jonathanp-okta
jonathanp-okta merged commit 5098c53 into master Aug 25, 2026
5 of 6 checks passed
@jonathanp-okta
jonathanp-okta deleted the add-decoder-unit-tests branch August 25, 2026 20:36

This branch was previously deployed

1 inactive deployment
preview — 01cc17f0 Deployed Nov 5, 2025 by christiansamaniego-okta via Deploy-Preview #137
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants