[test] correct CRL test to be agnostic of local TZ - #377
Open
chadlwilson wants to merge 1 commit into
Open
chadlwilson wants to merge 1 commit into
chadlwilson wants to merge 1 commit into
Conversation
This test fails if running in a local TZ that greater than UTC+6, because it incorrectly fails to normalize to UTC before extracting the date from a zoned timestamp inside a CRL. The actual CRL has `revocationDate utcTime Time UTCTime 2014-07-07 18:31:35 UTC`. In UTC+8, that time is not the 7th July; it's the 8th. Signed-off-by: Chad Wilson <29788154+chadlwilson@users.noreply.github.com>
chadlwilson
force-pushed
the
fix-test
branch
from
September 22, 2026 16:58
ef5329a to
75c8da5
Compare
chadlwilson
changed the title
Contributor
Author
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This test fails if running in a local TZ that greater than UTC+6, because it incorrectly fails to normalize to UTC before extracting the date from a zoned timestamp inside a CRL. The actual CRL has
revocationDate utcTime Time UTCTime 2014-07-07 18:31:35 UTC.In UTC+8, that time is not the 7th July; it's the 8th. Need to declare/convert zones properly.