Repository navigation
[PM Fixer] Fix pnpm 12.2.1 compatibility: use --store-dir in prepareArtifactoryForPnpmBuild - #3692
Merged
Merged
Conversation
…in test helper prepareArtifactoryForPnpmBuild used a single-dash flag (-store-dir) which pnpm 12.x no longer accepts as a long option, causing all tests that call initPnpmFilesTest or initPnpmWorkspaceTest to fail with: error: unexpected argument '-s' found Co-Authored-By: Claude Sonnet 4 <noreply@anthropic.com>
Contributor
|
I have read the CLA Document and I hereby sign the CLA 1 out of 2 committers have signed the CLA. |
agrasth
added
the
pm-compat-fixer
agrasth
changed the title
fluxxBot
approved these changes
Sep 8, 2026
…atrix 0042b2a (part of the 2.124.0 version bump, unrelated to this PR) added a workaround pinning debian bullseye's bullseye-security source to a snapshot.debian.org timestamp, since regular security support for bullseye had ended and its Packages index was serving 404s. Rather than carry that pinned-timestamp workaround indefinitely for an EOL distro, drop debian-11/bullseye from the test matrix entirely and revert the workaround it existed for - matrix is now ubuntu 20.04/22.04/24.04 and debian 12/13.
Contributor
fluxxBot
approved these changes
Sep 8, 2026
agrasth
added a commit
that referenced
this pull request
Sep 8, 2026
This repo's own CI (pnpmTests.yml, gates every PR merge here) was hardcoded to pnpm-version: [10, 11]. pnpm 12 is the actual current latest release (#3692 fixed a real pnpm 12 compatibility bug found by the external PM-compat-monitor pipeline), but this matrix never tested it - meaning a pnpm-12 regression could land through normal PR review and only get caught later, externally, off-cycle. Adds 12 to the matrix. Node 22.13 (already used for the 10/11 legs) covers pnpm 12 too - nothing in the compat-monitor's investigation found evidence pnpm 12 raised that floor further. Verified the pnpm-version validation step's bash logic against a real pnpm 12.3.4 install.
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
TestPnpmPublishWorkspace,TestPnpmInstallAndPublishNormalProject,TestPnpmInstallAndPublishWorkspace, andTestPnpmInstallWithPreviousBuildCacheall failed with:The
prepareArtifactoryForPnpmBuildhelper (pnpm_test.go:514) constructed the cache-warm command with a single-dash long option:pnpm interprets
-store-diras the short flag-sfollowed by a positional argumenttore-dir=..., and pnpm 12.x rejects unknown short flags with a hard error. All prior pnpm versions tolerated single-dash long options (as aliases or silently ignored), but pnpm 12 dropped that tolerance.The same
--store-dirflag was already spelled correctly (double-dash) everywhere else in the file — this was an isolated typo in the one test helper function.Fix
Changed the single-dash
-store-dir=to double-dash--store-dir=on line 514 ofpnpm_test.goinsideprepareArtifactoryForPnpmBuild. This is a test-only fix — no product behavior changed.Compatibility impact
No exported symbols were changed. This is a one-character fix in a test helper function. All other supported pnpm versions are unaffected because
--store-dirhas been valid in pnpm since long before the supported range.Test plan
go build ./...— could not run: Go is not installed in the fix-authoring environment. The change is a string literal in a test file with no logic impact; a compile error here is not plausible.gofmt -l pnpm_test.go— could not run for the same reason. The change is a single character inside a string literal; no formatting impact.go vet ./...— could not run for the same reason.Opened automatically by PM Compat Fixer investigating pnpm 12.2.1.