Repository navigation
Merge hotfix 1.2.5 into develop - #68
Merged
Merged
Conversation
Hotfix 1.2.5: fix app:apikeys:add on bind-mounted .env.local
Open
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #68 +/- ##
=============================================
+ Coverage 72.89% 74.39% +1.49%
- Complexity 232 264 +32
=============================================
Files 29 30 +1
Lines 653 738 +85
=============================================
+ Hits 476 549 +73
- Misses 177 189 +12
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Merge hotfix 1.2.5 (#67) back into
develop.Changes
1.2.5:app:apikeys:addwrites.env.localin place instead ofrename(), so it works when.env.localis a single-file bind mount (prod).src/Command/ApiKeysAddCommand.php: took 1.2.5's backup step (nochmod()); the rest of the file keepsdevelop's Rector changes.tests/Command/ApiKeysAddCommandTest.php: keptdevelop's$this->assert*style and added 1.2.5's inode assertion.CHANGELOG.md: keptdevelop's[Unreleased]list, added the[1.2.5]section above[1.2.4]and the footer link ([Unreleased]from1.2.5).Why
Gitflow: hotfixes merged to
mainmust be merged back intodevelop. Full test suite (265), PHPStan, Rector and php-cs-fixer pass locally.The same branch is merged into
release/1.3.0(#62) so the release carries the fix.