Skip to content

Changed COMPOSE_USER to runner - #121

Merged
tuj merged 2 commits into
developfrom
feature/compose-user-runner
Nov 17, 2025
Merged

Changed COMPOSE_USER to runner#121
tuj merged 2 commits into
developfrom
feature/compose-user-runner

Conversation

@tuj

@tuj tuj commented Nov 17, 2025

Copy link
Copy Markdown
Contributor

No description provided.

@tuj
tuj requested a review from turegjorup November 17, 2025 12:58
@tuj tuj self-assigned this Nov 17, 2025
@tuj tuj added the bug Something isn't working label Nov 17, 2025
turegjorup
turegjorup approved these changes Nov 17, 2025
View reviewed changes

@turegjorup turegjorup left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved - but please fix markdown linting errors for CHANGELOG.md

@tuj
tuj merged commit 953d1b0 into develop Nov 17, 2025
18 checks passed
@tuj
tuj deleted the feature/compose-user-runner branch November 17, 2025 13:15
@rimi-itk

rimi-itk commented Nov 17, 2025

Copy link
Copy Markdown
Contributor

@tuj @turegjorup are we sure that this also works for images that don't have a runner user (I'm not sure if the Prettier and Markdownlint images we use do)?

@turegjorup

turegjorup commented Nov 17, 2025

Copy link
Copy Markdown
Contributor

@tuj @turegjorup are we sure that this also works for images that don't have a runner user (I'm not sure if the Prettier and Markdownlint images we use do)?

Good catch. And no we´re not. I don't know if Prettier Markdown has a runner user or if it's tested.

@tuj

tuj commented Nov 18, 2025

Copy link
Copy Markdown
Contributor Author

@tuj @turegjorup are we sure that this also works for images that don't have a runner user (I'm not sure if the Prettier and Markdownlint images we use do)?

Good catch. And no we´re not. I don't know if Prettier Markdown has a runner user or if it's tested.

We do not specify COMPOSE_USER for prettier and markdown actions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@turegjorup turegjorup turegjorup approved these changes

Assignees

@tuj tuj

Labels

bug Something isn't working

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@tuj @rimi-itk @turegjorup