Repository navigation
[#479] Return iRODS error codes for write operations (main) - #502
Merged
Merged
Conversation
Contributor
Author
|
Forgot to add the compile-time logic for when the application is compiled against iRODS 5.0.2 and earlier. Will do that next. |
Contributor
Author
|
Compiled against 4.3 and irods/irods tip-of-main. Tested each build against irods/irods tip-of-main. This is ready for review now. |
alanking
reviewed
Jun 16, 2026
Contributor
Author
|
Confirmed that tests pass when compiled against iRODS 5. Working on a build which compiles against a dev package that doesn't have the dstream enhancement. |
Contributor
Author
|
Confirmed that a build against the 4.3 dev package passes the tests. Awaiting feedback. |
Contributor
Author
|
Squashed. |
Contributor
Author
|
Added pounds. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
All non-OIDC tests pass.
I've verified the following operations report error codes from the Logical Quotas rule engine plugin too. The error codes come from the plugin and iRODS server.
write- returnsSYS_NOT_ALLOWEDon violationsparallel_write_init- returnsSYS_NOT_ALLOWEDon violationstouch- returnsRE_RUNTIME_ERRORTesting covered limits on the number of data objects and bytes.
I think this puts the HTTP API in a good spot. Improvements to error codes have to be addressed in the plugin and/or the iRODS server.