Repository navigation
IPAG-8697 fix: incorpora #8 (warnings no PHP 8.x, README e CI com PHP 8.3/8.4) - #13
Merged
Merged
Conversation
….3/8.4 no CI Consolida em um único commit o trabalho do PR #8 (Edson Nascimento): - docs: corrige exemplos dos métodos do payment no README (getByTid, getByOrderId, captureBy*, cancelBy*) - fix: evita deprecation do preg_replace com null no Address::zipcode - fix: evita deprecation do DateTime::createFromFormat com null nos models - chore: adiciona matriz de PHP 7.4, 8.3 e 8.4 no CI, atualiza actions/checkout para v4 e adiciona cache do composer O conflito em .github/workflows/ci-tests.yml foi resolvido aplicando as melhorias sobre a versão atual do master, mantendo o test-reporter do Code Climate fixado em v0.11.1 e enviando o report apenas pela execução do PHP 7.4. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Complementa as correções do PR #8 nos pontos que ele não cobria, que quebram os testes na nova matriz do CI (convertDeprecationsToExceptions): - PaymentLinkV2::expires_at e SubscriptionV2::starting_date passavam null para DateTime::createFromFormat (mesmo caso já corrigido nos outros models) - Bank::setAccount declarava parâmetro implicitamente nullable, deprecated no PHP 8.4 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resumo
Consolida o trabalho do #8 (@edson-nascimento), que estava em conflito com o master, e complementa com as correções que faltavam para a nova matriz de PHP do CI passar.
Commits
686bd49 (autoria: Edson Nascimento): squash dos 4 commits do #8
paymentno README (getByTid,getByOrderId,captureBy*,cancelBy*)preg_replacecom null emAddress::zipcodeDateTime::createFromFormatcom null nos modelsactions/checkout@v4e cache do composerci-tests.ymlresolvido sobre o master atual, mantendo o test-reporter do Code Climate fixado emv0.11.1e enviando o report apenas pelo job do PHP 7.44db912a: corrige os pontos que o #8 não cobria (código adicionado depois dele, no #12)
PaymentLinkV2::expires_ateSubscriptionV2::starting_datepassavam null paracreateFromFormatBank::setAccountdeclarava parâmetro implicitamente nullable (deprecated no PHP 8.4)Testes
PHPUnit (461 testes), rodado localmente em Docker:
Os erros no master são deprecations convertidas em exceção pelo
phpunit.xml(convertDeprecationsToExceptions="true"). Não há mudança de comportamento: datas null continuam resultando em null, e o CEP null continua resultando em''.Substitui o #8.
Task: IPAG-8697
🤖 Generated with Claude Code