Repository navigation
feat(button): add the subtle hue #31649
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Open
Changes from all commits
Commits
Show all changes
31 commits
Select commit
Hold shift + click to select a range
df49658
feat(button): add the subtle hue
thetaPC 2ab5a91
Merge remote-tracking branch 'origin/FW-6838-icon-only' into FW-6838-hue
thetaPC 5a68deb
Merge remote-tracking branch 'origin/FW-6838-icon-only' into FW-6838-hue
thetaPC 4c8c1c1
Merge remote-tracking branch 'origin/FW-6838-icon-only' into FW-6838-hue
thetaPC 9fea1f2
Merge remote-tracking branch 'origin/FW-6838-icon-only' into FW-6838-hue
thetaPC 7244739
Merge remote-tracking branch 'origin/FW-6838-icon-only' into FW-6838-hue
thetaPC 16be625
test(button): check subtle hue contrast with axe
thetaPC abac442
Merge remote-tracking branch 'origin/FW-6838-icon-only' into FW-6838-hue
thetaPC 96bdecb
Merge remote-tracking branch 'origin/FW-6838-icon-only' into FW-6838-hue
thetaPC 263164b
Merge remote-tracking branch 'origin/FW-6838-icon-only' into FW-6838-hue
thetaPC 9d6413d
test(button): rename the subtle a11y color list
thetaPC 11bd774
Merge remote-tracking branch 'origin/FW-6838-icon-only' into FW-6838-hue
thetaPC 505743b
Merge remote-tracking branch 'origin/FW-6838-icon-only' into FW-6838-hue
thetaPC 05eed51
Merge remote-tracking branch 'origin/FW-6838-icon-only' into FW-6838-hue
thetaPC e6edaea
test(button): loop over the fills array in the subtle hue a11y test
thetaPC d889424
Merge remote-tracking branch 'origin/FW-6838-icon-only' into FW-6838-hue
thetaPC 6e010c3
fix(button): use foreground for outline text in md and ios
thetaPC df9450a
test(button): note the tests that don't vary by direction
thetaPC 2136c87
Merge remote-tracking branch 'origin/FW-6838-icon-only' into FW-6838-hue
thetaPC 9e73e30
Merge remote-tracking branch 'origin/FW-6838-icon-only' into FW-6838-hue
thetaPC c8675b1
Merge remote-tracking branch 'origin/FW-6838-icon-only' into FW-6838-hue
thetaPC 80796d1
Merge remote-tracking branch 'origin/FW-6838-icon-only' into FW-6838-hue
thetaPC 20c61d5
Merge remote-tracking branch 'origin/FW-6838-icon-only' into FW-6838-hue
thetaPC 5d7b07f
Merge remote-tracking branch 'origin/FW-6838-icon-only' into FW-6838-hue
thetaPC 85113e1
Merge remote-tracking branch 'origin/FW-6838-icon-only' into FW-6838-hue
thetaPC f61cd69
Merge remote-tracking branch 'origin/FW-6838-icon-only' into FW-6838-hue
thetaPC 8c1b217
test(button): render the hue test with setContent, one snapshot per hue
thetaPC be0dfa9
Merge remote-tracking branch 'origin/FW-6838-icon-only' into FW-6838-hue
thetaPC 02c2593
Merge remote-tracking branch 'origin/FW-6838-icon-only' into FW-6838-hue
thetaPC dd12cad
test(button): size the hue viewport to the content
thetaPC 8c3150f
Merge remote-tracking branch 'origin/FW-6838-icon-only' into FW-6838-hue
thetaPC File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The revert only covers outline, but the ios clear semantic hover and focus colors changed too. Could we add
IonButton.hue.bold.clear.semantic.<state>.colorand--ion-button-hue-bold-clear-semantic-<state>-colorhere as well?