Repository navigation
Conversation
thetaPC
added this pull request to stack #31629
October 23, 2026 22:58
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
1 of 2 tasks
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue number: resolves internal
What is the current behavior?
A badge without a
verticalposition sits against the button's label with no gap. In md and ios, a badge taller than the label also makes the button taller, so buttons of the same size have different heights.What is the new behavior?
verticalposition in a text button has a gap from the label, set by the newIonButton.size.<size>.badge.margintoken: 8px, 10px and 12px in ionic, 8px, 8px and 12px in md, and 4px in ios, the same as each theme's icon gapmin.heightand a tall badge no longer grows it.--padding-topand--padding-bottomstill override thisverticalposition don't changeDoes this introduce a breaking change?
A badge without a
verticalposition now has a gap between it and the label, and no longer makes the button taller than itsmin.height. To remove the gap, setIonButton.size.<size>.badge.margin.startfor global styles or--ion-button-size-<size>-badge-margin-startfor component-specific styles to0.Other information