Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion core/src/components/title/test/color/title.e2e.ts
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,11 @@ import { configs, test } from '@utils/test/playwright';
/**
* Color doesn't change with direction, so this only runs ltr.
*/
configs({ modes: ['ionic-md', 'md', 'ios'], directions: ['ltr'] }).forEach(({ title, screenshot, config }) => {
configs({
modes: ['ionic-md', 'md', 'ios'],
directions: ['ltr'],
palettes: ['light', 'dark', 'high-contrast', 'high-contrast-dark'],
}).forEach(({ title, screenshot, config }) => {
test.describe(title('title: color'), () => {
test('should apply the color to the title text', async ({ page }) => {
await page.goto('/src/components/title/test/color', config);
Expand Down
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
6 changes: 5 additions & 1 deletion core/src/components/title/test/hue/title.e2e.ts

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are the palette screenshots needed for title (and potentially other components)? The palettes only change the color values, not which token title uses (bold → base, subtle → the subtle foreground), and that choice is already covered by the light screenshots. None of the palette token files has an IonTitle override, and the palette colors themselves are already tested across all four palettes in themes/native/test/colors and themes/ionic/test/colors. The ionic-md high-contrast screenshots are also byte-identical to light, since ionic has no high-contrast palette. I'd drop these. If native subtle colors need palette coverage, themes/native/test/colors seems like the better place, since it covers every component with hue. Let me know if you disagree.

Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,11 @@ import { HUES } from '../../../../themes/themes.interfaces';
*
* `ios` is the same as `md`.
*/
configs({ directions: ['ltr'], modes: ['md', 'ionic-md'] }).forEach(({ title, screenshot, config }) => {
configs({
directions: ['ltr'],
modes: ['md', 'ionic-md'],
palettes: ['light', 'dark', 'high-contrast', 'high-contrast-dark'],
}).forEach(({ title, screenshot, config }) => {
test.describe(title('title: hue'), () => {
test.beforeEach(async ({ page }) => {
await page.goto('/src/components/title/test/hue', config);
Expand Down
Loading