fix(inputs.vault): Decode float values of gauges and counters - #19733
Merged
Merged
Conversation
srebhan
requested changes
Sep 16, 2026
srebhan
left a comment
Member
There was a problem hiding this comment.
@skartikey we cannot do this change without a config setting as this will break nearly every user. Please add an option to keep ints by default with a warning about that the default for the option will change in say v1.45.0 outputting float values by default. We still keep the option to opt-out to the old types...
Then in v1.45.0 we deprecate the option for v1.50.0...
Contributor
|
Download PR build artifacts for linux_amd64.tar.gz, darwin_arm64.tar.gz, and windows_amd64.zip. 📦 Click here to get additional PR build artifactsArtifact URLs |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Vault reports gauge values and the sum, min and max of counters as floating point numbers, but the plugin decoded them into integers. As soon as one of them has a fractional part, like
vault.wal.write_controller.idle_secsin the linked issue, decoding the response fails and no metric is collected at all.This PR always decodes those values as floats, so the response parses again. To avoid field type conflicts for existing users, the new
float_valuesoption defaults tofalseand keeps emitting integers by truncating the values, whilefloat_values = trueoutputs the floats as reported by Vault. If the option is not set, a warning announces that the default changes totruein v1.45.0.Checklist
Related issues
resolves #19672