Repository navigation
fix: skip sparse array holes in optimized filter - #1320
Open
xianjianlf2 wants to merge 1 commit into
Open
xianjianlf2 wants to merge 1 commit into
xianjianlf2 wants to merge 1 commit into
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With
enableArrayMethods(), filtering a sparse array calls the predicate for empty slots. For example,produce(new Array(3), draft => draft.filter(() => true))returns threeundefinedvalues instead of[]; a predicate that reads an object property can also throw on a hole.Check whether each index exists before invoking the predicate, matching native
filter. Explicitundefinedelements are still visited, and selected objects remain drafts whose mutations update the original positions.The tests run with the plugin and auto-freezing independently enabled and disabled. Four cases fail before the fix. On Node 24.18.0,
yarn testpasses: 3,844 source tests and 3,293 production-build tests, with eight existing skips in each suite; the build and Flow checks pass. Prettier andgit diff --checkalso pass.Prepared with AI assistance, including code and regression tests.