Repository navigation
feat: Add oven attributes and core:FirmwareRevisionState - #2319
Merged
Merged
Conversation
Adds a Sauter / Brandt oven (ogp:Oven, DynamicOven) setup fixture from home-assistant/core#189108 and regenerates the enums from it.
10 of 21 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds the oven states and attributes that are missing from pyoverkiz. They were found by comparing the fixture from home-assistant/core#189108 (Sauter / Brandt SOP6615LB,
ogp:Oven, widgetDynamicOven) against the current enums.Adds that setup as a test fixture, then regenerates the enums from it via
utils/generate_enums.py.Changes
tests/fixtures/setup/setup_sauter_oven.json(1 device, Sauter cloud, already anonymized in the Home Assistant PR).pyoverkiz/enums/state.pyOverkizAttribute:CORE_SUBSET_ID,CORE_SUPPORTED_CYCLE_STAGES,CORE_SUPPORTED_INTENSITIES,CORE_SUPPORTED_MODES_BY_CATEGORY,CORE_SUPPORTED_RECIPES,CORE_SUPPORTED_RECIPES_BY_CATEGORY,CORE_TARGET_TIME_LOWER_BOUND,CORE_TARGET_TIME_UPPER_BOUND,CORE_TARGET_WEIGHT_LOWER_BOUND,CORE_TARGET_WEIGHT_UPPER_BOUNDOverkizState:CORE_FIRMWARE_REVISION_STATE = "core:FirmwareRevisionState". The generator skipped this state because its default nameCORE_FIRMWARE_REVISIONis already taken by the existing (legacy)OverkizState.CORE_FIRMWARE_REVISION = "core:FirmwareRevision". It was added under a_STATEsuffix so the existing member is left unchanged. Regenerating keeps the name.tests/test_client.py: added the fixture to thetest_get_setupandtest_get_diagnostic_dataparametrize lists.All other states, commands, the widget, the UI class and the UI profiles of this device were already present.