Repository navigation
Add tests-without-private-imports hook - #3
Open
sverhoeven wants to merge 1 commit into
Open
sverhoeven wants to merge 1 commit into
sverhoeven wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #2
Adds a third independently selectable hook,
tests-without-private-imports, that rejects importing private names or modules into tests. Tests should use the public API; either make the name public or test its public caller.Blocked (rule
no-private-imports-in-tests):from foo import _bar(also aliased, in mixed/parenthesised lists, inside functions)from foo._internal import x,import foo._bar,from _pytest.monkeypatch import MonkeyPatchAllowed:
__version__,from __future__ import annotations), a lone_import foo as _foo)from .helpers import _build) so tests can share private helpersNot checked: attribute access such as
foo._bar().Stacked on #1 (
no-if-in-tests); merge that first. Also updatesrename.mdwith naming options for the new hook.