Repository navigation
feat(backend): compile the 43 orphaned src-gossamer modules in the lib - #153
Merged
Merged
Conversation
These 43 modules were declared by no crate root, so `cargo fmt` never reached them. Formatting only, no code changes, so the next commit's diff (wiring them into the lib) carries only real edits. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01SJtjqoZaSQo7uBwvwVMA9G
43 modules under src-gossamer/src/ were declared by no crate root, so they were never compiled, linted or tested. None needs gossamer_rs, so all are now `pub mod` in lib.rs and build without the optional `gossamer` feature. main.rs still adds only system_tray. `cargo test --lib` now runs 285 tests (was 23). Fixes needed once the code compiled (clippy -D warnings, rustdoc): - 221 blank lines between a doc comment and its fn, left where #[tauri::command] attributes were deleted - minter_mint_panel takes a MintRequest instead of 12 positional args (too_many_arguments); generate_panel_manifest drops an unused param - a2ml, cloudguard, farm, script_gist, security: if_same_then_else, bind_instead_of_map, for_kv_map, wildcard_in_or_patterns, useless_format, manual_strip - tests: single_match (a2ml), irrefutable let (valence_shell), always-true len() >= 0 assert (release_manager) - compat::AppHandle derives Default (new_without_default) - bare URL (watcher) and unescaped <id> (identity) in rustdoc Tauri leftovers removed from compat, error (to_tauri_result is now to_command_result), cloudguard::commands and ums_cartridge::commands. The handlers are not yet registered in register_commands (main.rs); that is follow-up work. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01SJtjqoZaSQo7uBwvwVMA9G
- Cargo.toml header claimed "All 103 command handlers are registered"; 36 are. It also said libgossamer.so is linked at runtime; gossamer-rs links libgossamer statically. - EXPLAINME-new.adoc claimed "270 migrated commands" and pointed at src-tauri/; it now says 36 registered, with the rest compiled and tested in the lib but not registered. - docs/TECHNICAL_DEBT.adoc: F1 census step done (43 modules, 285 lib tests). - CHANGELOG entry. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01SJtjqoZaSQo7uBwvwVMA9G
Contributor
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 50 minutes. View limit details
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Hypatia code scanning flagged the expect() (CWE-754) once rustfmt re-wrapped the line. It could not fire, because an is_empty() check returned first, but `let Some(latest) = recordings.last() else` covers both cases with no panic path. The separate guard and its wrong "line 146" comment are gone. Behaviour is unchanged. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01SJtjqoZaSQo7uBwvwVMA9G
hyperpolymath
marked this pull request as ready for review
October 14, 2026 11:23
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
43 modules under
src-gossamer/src/were declared by no crate root, so they were never compiled, linted or tested. None of them needsgossamer_rs, so all 43 are nowpub modinlib.rsand build without the optionalgossamerfeature.main.rsstill adds onlysystem_tray.cargo test --lib: 285 passed (was 23).The modules: a2ml, aerie, ai, boj, boj_live, capture, clade_scanner, cloudguard, compat, dlc_workshop, echidna_live, error, farm, feedback, fleet, game_preview, governance, hypatia, k9, level_architect, minter, multiplayer_monitor, network_topology, observability, overlay, plaza, provenance, release_manager, repoloader, script_gist, security, system_update, typell, umoja, ums, ums_cartridge, valence_shell, verisim_live, vm_inspector, voicetag, watcher, wiring_inspector, workspace.
Commits (review them one at a time)
style(backend): rustfmt …: formatting only, about 1,100 lines.cargo fmthad never reached these files. You can skip this one.feat(backend): compile …: the real change, mostly deletions:fn, left behind when#[tauri::command]attributes were deleted (clippy::empty_line_after_doc_comments).minter_mint_panelnow takes aMintRequestinstead of 12 positional arguments (too_many_arguments). That struct already derivesDeserializefor exactly this payload, so IPC registration can doserde_json::from_value::<MintRequest>(payload)likellm_coding_spawn.generate_panel_manifestdrops an unused parameter.a2ml_list's doc.single_match, an irrefutableif let, and an always-truelen() >= 0assert.compat::AppHandlederivesDefault.watcherand an unescaped<id>inidentity. Theidentityone already fails onmain.compat,error(to_tauri_result→to_command_result),cloudguard::commandsandums_cartridge::commands.docs: …:Cargo.tomlheader claimed "All 103 command handlers are registered"; 36 are. It also said libgossamer is linked at runtime as a.so; it is linked statically.EXPLAINME-new.adocclaimed "270 migrated commands" and linkedsrc-tauri/; both now match the code.docs/TECHNICAL_DEBT.adoc: the F1 census step is marked done.Not in this PR
register_commands(main.rs). That is the follow-up.src-tauristrings inminterandrepoloader, which point at other repos' layouts or generated output, and theidaptik-ums/src-tauri/...path inums_cartridge, which names a file in another repo.cargo clippy --features gossamer --all-targets -D warningsfails onSystemTrayStatedead code in the bin's test target. That failure already exists onmain, and no CI job runs that command.Verification (default features, local)
cargo check --locked --all-targets: cleancargo clippy --locked --all-targets -- -D warnings: cleancargo fmt --all -- --check: cleancargo test --locked --all-targets: 285 passed. Five repeat runs and--test-threads=1(as build-validation runs it) were also clean.cargo test --locked: 285 passed, plus 2 doctests (bothignore)RUSTDOCFLAGS="-D warnings" cargo doc --no-deps: cleancargo build --features gossamer --bin panll-gossamer: not verified here. The container has no Zig 0.15.2 and no GTK/WebKit. Instead I rancargo check --features gossamer --bin panll-gossameragainst the real pinned gossamer-rs, withGOSSAMER_LIB_DIRpointing at an emptylibgossamer.aand stub.pcfiles. It type-checks clean. The e2e workflow will do the real build and link.One side effect:
feedback's test writes a report under~/.panll/feedback/and deletes the file, but leaves the empty directory. The other new tests write under/tmp/panll.🤖 Generated with Claude Code
https://claude.ai/code/session_01SJtjqoZaSQo7uBwvwVMA9G
Generated by Claude Code