Repository navigation
Look up only the packages that dependency notifications need - #1537
Merged
Merged
Conversation
The notification job fetched the whole package index to check whether an upload was the newest version and to find the latest version of each reverse dependency. It now reuses the uploaded packages it has already looked up, and takes the latest version of each reverse dependency from the reverse index, which also holds that version's dependencies. Reading both from the same snapshot of the reverse index means a reverse dependency that gets a new version while the job runs can no longer be skipped for lacking dependencies in the reverse index. A deleted latest version of a reverse dependency is still used, because the reverse index never removes versions.
Contributor
|
This pull request does not currently match the merge queue conditions, so it cannot be queued from here. The box comes back if it matches again. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Continuation of #1524.
The notification job fetched the whole package index to check whether an
upload was the newest version and to find the latest version of each
reverse dependency. It now reuses the uploaded packages it has already
looked up, and takes the latest version of each reverse dependency from
the reverse index, which also holds that version's dependencies.
Reading both from the same snapshot of the reverse index means a reverse
dependency that gets a new version while the job runs can no longer be
skipped for lacking dependencies in the reverse index. A deleted latest
version of a reverse dependency is still used, because the reverse index
never removes versions.
Tested locally.