Skip to content

chore: tool-neutral agent setup, AGENTS.md PR rules and agent leftovers check - #1056

Merged
dkhawk merged 2 commits into
mainfrom
chore/agent-tooling
Oct 29, 2026
Merged

dkhawk merged 2 commits into
mainfrom
chore/agent-tooling

Conversation

@kikoso

@kikoso kikoso commented Oct 29, 2026

Copy link
Copy Markdown
Collaborator

Makes the agent setup tool-neutral, adds pull request rules that came up repeatedly in recent reviews, and adds a CI check for leftovers of local or agent-assisted work.

Tool-neutral setup

  • The skill moves from .gemini/skills/ to .agents/skills/. .claude/skills and .gemini/skills are symlinks to it, so Claude Code, Gemini CLI and Codex all find the same skill.
  • GEMINI.md imports AGENTS.md, like CLAUDE.md already does.
  • Every reference to the old path moves with it: release-please-config.json, release-rc.yml, update_skill.py and answer_issue.py. release-please and the RC workflow edit the real file, not a symlink.
  • .gemini/config.yaml and .gemini/styleguide.md stay where they are, since they configure Gemini Code Assist reviews.

AGENTS.md

  • New "Agent setup" section describing the layout above.
  • Pull request rules: keep a PR to what its title says (and fix the type if the scope changes), answer every review thread before asking for another review, and never commit local paths, internal links, bug IDs or API keys.

Agent leftovers check

.github/workflows/agent-leftovers.yml runs .github/scripts/check_agent_leftovers.py on every pull request. It scans only what the PR adds (added lines, new file names, commit messages, title and body) for:

  • local paths and file:// URLs into home or temp directories
  • go/ links, b/ bug IDs, corp and googleplex hosts
  • Google API keys
  • AI co-author trailers and links to agent chat sessions
  • local agent settings files and .orig/.rej merge leftovers

A line can opt out with agent-leftovers: ignore. Findings show as annotations on the PR.

Tested against the last 250 commits on main of this repo, android-maps-utils and android-places-compose: it flags two real cases (agent session links in commit messages) and no false positives, plus a synthetic commit that triggers every pattern.

Notes

Adds an Agent leftovers check that scans only what a pull request adds (diff lines, new file names, commit messages, title and body) for local paths, internal links and bug IDs, Google API keys, AI co-author trailers and agent session links. A line can opt out with "agent-leftovers: ignore".
Moves the skill to .agents/skills, with .claude/skills and .gemini/skills as symlinks, adds GEMINI.md importing AGENTS.md, and documents the setup in AGENTS.md together with pull request rules for scope, review threads and machine-specific content.
@github-actions

Copy link
Copy Markdown

Coverage (unit tests)

Compared against 3f9353b on main (#1043).

Module Line % Change Branch % Change
maps-compose 15.28% no change 3.76% no change
maps-compose-utils 6.09% no change 4.47% no change
maps-compose-widgets 0.00% no change 0.00% no change
TOTAL 12.41% no change 3.79% no change

Line and branch coverage from unit test reports. History is recorded on the coverage-history branch after each merge to main.

@kikoso
kikoso marked this pull request as ready for review October 29, 2026 17:17
@kikoso
kikoso requested a review from a team as a code owner October 29, 2026 17:17
@googlemaps-bot

Copy link
Copy Markdown
Contributor

Coverage (instrumentation tests)

Overall Project 43.54% 🍏

There is no coverage information present for the Files changed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants