Repository navigation
chore: tool-neutral agent setup, AGENTS.md PR rules and agent leftovers check - #1056
Merged
Merged
Conversation
Adds an Agent leftovers check that scans only what a pull request adds (diff lines, new file names, commit messages, title and body) for local paths, internal links and bug IDs, Google API keys, AI co-author trailers and agent session links. A line can opt out with "agent-leftovers: ignore".
Moves the skill to .agents/skills, with .claude/skills and .gemini/skills as symlinks, adds GEMINI.md importing AGENTS.md, and documents the setup in AGENTS.md together with pull request rules for scope, review threads and machine-specific content.
Coverage (unit tests)Compared against
Line and branch coverage from unit test reports. History is recorded on the |
Contributor
Coverage (instrumentation tests)
|
dkhawk
approved these changes
Oct 29, 2026
This was referenced Oct 29, 2026
Open
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Makes the agent setup tool-neutral, adds pull request rules that came up repeatedly in recent reviews, and adds a CI check for leftovers of local or agent-assisted work.
Tool-neutral setup
.gemini/skills/to.agents/skills/..claude/skillsand.gemini/skillsare symlinks to it, so Claude Code, Gemini CLI and Codex all find the same skill.GEMINI.mdimportsAGENTS.md, likeCLAUDE.mdalready does.release-please-config.json,release-rc.yml,update_skill.pyandanswer_issue.py. release-please and the RC workflow edit the real file, not a symlink..gemini/config.yamland.gemini/styleguide.mdstay where they are, since they configure Gemini Code Assist reviews.AGENTS.md
Agent leftovers check
.github/workflows/agent-leftovers.ymlruns.github/scripts/check_agent_leftovers.pyon every pull request. It scans only what the PR adds (added lines, new file names, commit messages, title and body) for:file://URLs into home or temp directoriesgo/links,b/bug IDs, corp and googleplex hosts.orig/.rejmerge leftoversA line can opt out with
agent-leftovers: ignore. Findings show as annotations on the PR.Tested against the last 250 commits on
mainof this repo, android-maps-utils and android-places-compose: it flags two real cases (agent session links in commit messages) and no false positives, plus a synthetic commit that triggers every pattern.Notes
update_skill.pygets a one-line path change, so it will conflict trivially with fix(ci): update Gemini model and harden update-skill against prompt injection #991, which fixes the failingUpdate Skillworkflow. Whichever merges second needs a small rebase..github/, so it needs a googlemaps-admin approval.