fix(snippets): clean up region tags, remove dummy getter blocks, and fix Kotlin/Java parity

[dkhawk]

Summary

Cleans up DevSite region tags and snippet bodies across :snippets:kotlin-app and :snippets:java-app following the PR #2427 migration:

• MapInitSnippets (maps_android_map_type & maps_android_map_fragment):
  • Fixes maps_android_map_type in MapInitSnippets.kt so it wraps map.mapType = GoogleMap.MAP_TYPE_HYBRID instead of map.setIndoorEnabled(true), and removes the extraneous indoor map enable/getter calls from both Kotlin and Java (maps_android_indoor_* snippets already exist in IndoorSnippets and EventsSnippets).
  • Exposes var mapType: Int on Kotlin TrackedMap.
  • Wraps the if (context is FragmentActivity) harness check in MapInitSnippets.kt (maps_android_map_fragment) in // [START_EXCLUDE silent] to match MapInitSnippets.java, and imports MapColorScheme in both files.
• Remove Artificial Unused Getter Blocks (MarkerSnippets, OverlaySnippets, ShapesSnippets):
  • Removes dead .let { ... } / if (... != null) { ... } blocks that assigned unused local variables for every getter on Marker, GroundOverlay, TileOverlay, Polyline, Polygon, and Circle (which were un-excluded in Kotlin and leaking into DevSite snippets).
• DatasetLayerSnippets & DataDrivenBoundarySnippets Region Tag Parity:
  • Wraps the sample app's custom Button filter UI in DatasetLayerSnippets.java inside // [START_EXCLUDE silent] and extends maps_android_dds_boulder_trails to include applyBoulderStyling(FeatureLayer layer).
  • Removes the _java suffix from region tags in DatasetLayerSnippets.java and DataDrivenBoundarySnippets.java so they match DatasetLayerSnippets.kt and DataDrivenBoundarySnippets.kt.
• UtilsSnippets & OverlaySnippets Cleanup:
  • Moves demo-app map.moveCamera(...) calls outside maps_android_markers_draggable, maps_android_utils_heatmap_simple, and maps_android_utils_heatmap_customize, and replaces fully-qualified com.google.android.gms.maps.* references with imports.
  • Adds @SnippetItem(title = "7b. Remove KML Layer", ...) to UtilsSnippets.kt, adds clusterManager.cluster() to maps_android_utils_clustering_info_window in UtilsSnippets.java, and uses provider.setWeightedData(data) in UtilsSnippets.java.
  • Fixes the corrupted Apache license URL in OverlaySnippets.kt.
• Catalog & Coverage Generator (catalog_api.py, CATALOG.md, COVERAGE.md):
  • Treats is* boolean getters the same as get*/set* when checking for missing non-getter/setter APIs.
  • Scans AGP 9's built_in_kotlinc output directory and skips Kotlin-only GoogleMapKt extensions in the Java coverage section.
  • Increases the @SnippetItem to [START ...] line window so 1. Dataset - Boulder Trails maps to maps_android_dds_boulder_trails.

Test Plan

• ./gradlew :snippets:kotlin-app:assembleDebug :snippets:java-app:assembleDebug
• python3 snippets/scripts/catalog_api.py (0 missing APIs in Kotlin and 0 in Java)

[snippet-bot]

Here is the summary of changes.

You are about to add 7 region tags.

• snippets/java-app/src/main/java/com/example/snippets/java/snippets/DataDrivenBoundarySnippets.java:59, tag maps_android_dds_locality_boundary
• snippets/java-app/src/main/java/com/example/snippets/java/snippets/DataDrivenBoundarySnippets.java:98, tag maps_android_dds_state_boundaries
• snippets/java-app/src/main/java/com/example/snippets/java/snippets/DataDrivenBoundarySnippets.java:137, tag maps_android_dds_country_interactive
• snippets/java-app/src/main/java/com/example/snippets/java/snippets/DatasetLayerSnippets.java:73, tag maps_android_dds_boulder_trails
• snippets/java-app/src/main/java/com/example/snippets/java/snippets/DatasetLayerSnippets.java:202, tag maps_android_dds_nyc_squirrels
• snippets/java-app/src/main/java/com/example/snippets/java/snippets/DatasetLayerSnippets.java:264, tag maps_android_dds_kyoto_temples
• snippets/kotlin-app/src/main/java/com/example/snippets/kotlin/snippets/UtilsSnippets.kt:397, tag maps_android_utils_kml_remove_layer

You are about to delete 7 region tags.

• snippets/java-app/src/main/java/com/example/snippets/java/snippets/DataDrivenBoundarySnippets.java:59, tag maps_android_dds_locality_boundary_java
• snippets/java-app/src/main/java/com/example/snippets/java/snippets/DataDrivenBoundarySnippets.java:98, tag maps_android_dds_state_boundaries_java
• snippets/java-app/src/main/java/com/example/snippets/java/snippets/DataDrivenBoundarySnippets.java:137, tag maps_android_dds_country_interactive_java
• snippets/java-app/src/main/java/com/example/snippets/java/snippets/DatasetLayerSnippets.java:73, tag maps_android_dds_boulder_trails_java
• snippets/java-app/src/main/java/com/example/snippets/java/snippets/DatasetLayerSnippets.java:190, tag maps_android_dds_nyc_squirrels_java
• snippets/java-app/src/main/java/com/example/snippets/java/snippets/DatasetLayerSnippets.java:252, tag maps_android_dds_kyoto_temples_java
• snippets/kotlin-app/src/main/java/com/example/snippets/kotlin/snippets/UtilsSnippets.kt:449, tag maps_android_utils_kml_remove_layer

---

This comment is generated by snippet-bot.
If you find problems with this result, please file an issue at:
https://github.com/googleapis/repo-automation-bots/issues.
To update this comment, add snippet-bot:force-run label or use the checkbox below:

• Refresh this comment

[kikoso]

With the END moved here, maps_android_dds_boulder_trails now covers two methods: it starts in the middle of styleBoulderTrails(), includes its closing brace and the signature of applyBoulderStyling, and ends before that method's closing brace. On DevSite the braces will look unbalanced. Could we either keep the styling inline like the Kotlin version (or a local lambda, like the Kyoto snippet does), or give applyBoulderStyling its own region tag?

[kikoso]

Just to double check: these _java tags only landed in #2426 on Oct 8, so I guess no DevSite page is pointing to them yet and renaming is safe, or do I miss anything?

[kikoso]

nit: the window going from 15 to 25 lines will probably break again with the next long description. Just a random idea: could we take the first [START ...] after the @SnippetItem line instead of a fixed window?

[kikoso]

LGTM! Nice cleanup, the snippets read much better without the getter blocks. Just a few minor comments, nothing blocking.