Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request configures test coverage reporting for the google-crc32c package, setting a 100% coverage requirement, enabling unit tests in pure Python mode, and handling missing C extensions during testing. The review feedback suggests using lowercase "# pragma: no cover" comments to ensure coverage.py correctly excludes lines, enabling parallel coverage tracking in .coveragerc to prevent parallel test runs from overwriting coverage data, and updating the cover session in noxfile.py to combine these parallel coverage files before generating the report.
|
It looks like the package is being passed over by the unit tests |
2baf953 to
851f38f
Compare
|
kokoro:force-run |
ohmayr
added
the
kokoro:force-run
yoshi-kokoro
removed
the
kokoro:force-run
Remove outdated TODO comments and specify technical rationale for skipping core and prerelease dependency sessions.
Configure PYTHONPATH to point directly to src/ and target coverage at src/google_crc32c to avoid editable install issues. Add unit tests for array checksums and CommonChecksum interface contract, document omissions for Windows DLL helper and C extension wrapper in .coveragerc, and annotate pure-Python C fallback import with pragma NO COVER. Fixes #17052
Directly test array.array buffer updating against the python Checksum implementation instead of the parameterized _crc32c fixture, avoiding TypeError when executed against the C-extension on Kokoro runners.
|
Hi @daniel-sanche, Thanks for pointing that out! The issue was that modern We have updated
Pure-Python unit tests and coverage now measure |
This branch has not been deployed
3 participants
feat: add unit and cover nox sessions and enforce 100% test coverage for google-crc32c
Fixes #17052