Conversation
Contributor
|
Note Gemini is unable to generate a review for this pull request due to the file types involved not being currently supported. |
bshaffer
changed the title
bshaffer
marked this pull request as ready for review
September 16, 2026 15:08
quirogas
reviewed
Sep 18, 2026
| run: npm install | ||
| working-directory: core/generator/gapic-generator-typescript | ||
| - name: Install global CLI tools | ||
| run: npm install -g @bazel/bazelisk pnpm@10.0.0 --silent |
Contributor
There was a problem hiding this comment.
Nit: could you use pnpm to install the generator.
Contributor
There was a problem hiding this comment.
I believe it would look similar to what librarian does to install it.
https://github.com/googleapis/google-cloud-node/blob/main/librarian.yaml#L28-L30
quirogas
approved these changes
Sep 18, 2026
bshaffer
marked this pull request as draft
September 18, 2026 22:39
bshaffer
marked this pull request as ready for review
September 18, 2026 22:49
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
package-lock.jsoningapic-generator-typescriptgenerator-tests.yamlandupdate-api-list.yamlfrom npm to pnpm so root only-allow pnpm succeeds.