Repository navigation
fix: add user agent to session path - #14835
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request introduces a custom UserAgentInterceptor to append a custom user-agent header to gRPC channels across different channel providers. The reviewer feedback suggests a cleaner and more efficient approach: instead of implementing a custom interceptor and forwarding client calls (which introduces unnecessary allocation overhead), the standard ManagedChannelBuilder.userAgent(String) method should be used to configure the user agent. Consequently, the custom interceptor, its associated metadata key, and the unused gRPC imports can be safely removed.
|
/gemini review |
There was a problem hiding this comment.
Code Review
This pull request updates ChannelProviders.java to append a custom user agent string (bigtable-java/) to the ManagedChannelBuilder instances created in various channel providers. There are no review comments to address, and we have no further feedback to provide.
| BigtableStubSettings.defaultApiClientHeaderProviderBuilder() | ||
| .build() | ||
| .getHeaders() | ||
| .get("x-goog-api-client"); | ||
|
|
There was a problem hiding this comment.
I think we should hardcode it. This kind of makes the interaction between gapic and jetstream worse. We should be aiming to keep jetstream a lower layer than gapic. We had to break that rule for the overly complex logic in InstantiatingGrpcChannelProvider. But here I think reward for breaking that rule is not justified. So I would jsut hard code
No description provided.