Repository navigation
feat(google/shopping/merchant/reviews/v1): add shopping-merchant-reviews - #14724
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request introduces the auto-generated v1 Java client library for the Google Shopping Merchant Reviews API, adding the client, stubs, settings, tests, and samples, alongside updating the build configurations. A critical issue was found in the generated pom.xml for google-shopping-merchant-reviews, where the grpc-google-shopping-merchant-reviews-v1 dependency is incorrectly scoped to test. This will cause runtime NoClassDefFoundError exceptions for production users. The generator configuration or source metadata should be updated to resolve this scope issue rather than editing the POM manually.
| <dependency> | ||
| <groupId>com.google.shopping.api.grpc</groupId> | ||
| <artifactId>grpc-google-shopping-merchant-reviews-v1</artifactId> | ||
| <scope>test</scope> |
There was a problem hiding this comment.
The dependency grpc-google-shopping-merchant-reviews-v1 is generated with test. This will prevent the gRPC classes (such as ProductReviewsServiceGrpc) from being available at runtime for production users of the v1 client library, leading to NoClassDefFoundError when they attempt to use the library. Since this pom.xml is auto-generated, please do not edit it manually. Instead, modify the generator configuration or the source metadata (e.g., in the upstream googleapis repository or generation scripts) to ensure this dependency is generated with the default (compile) scope, similar to grpc-google-shopping-merchant-reviews-v1beta.
References
- Avoid manually editing auto-generated files (such as pom.xml in generated client libraries) because changes will be overwritten. Modify the generator or the source metadata instead.
|
Hi @jinseopkim0 @whowes, could you please take a look at this library onboarding PR when you get a chance? Thanks! |
| api_description_override: Programmatically manage your Merchant Center Accounts. | ||
| artifact_id: google-shopping-merchant-reviews | ||
| client_documentation_override: https://cloud.google.com/java/docs/reference/google-shopping-merchant-reviews/latest/overview | ||
| group_id: com.google.shopping |
There was a problem hiding this comment.
It's nice that it's already under group_id: https://central.sonatype.com/artifact/com.google.shopping/google-shopping-merchant-reviews
2 participants
Onboard google/shopping/merchant/reviews/v1 API (shopping-merchant-reviews).
Internal tracking bug http://b/574418635
PiperOrigin-RevId: 1000790478
Debug Info
System Details
Commands Executed
MAVEN_SKIP_RC=true go run github.com/googleapis/librarian/cmd/librarian@v0.49.0 installgo run github.com/googleapis/librarian/cmd/librarian@v0.49.0 add google/shopping/merchant/reviews/v1go run github.com/googleapis/librarian/cmd/librarian@v0.49.0 generate shopping-merchant-reviewsmvn -B -ntp compile -pl :google-shopping-merchant-reviews -amgo run github.com/googleapis/librarian/cmd/librarian@v0.49.0 tidygit add .git commit -m "feat(google/shopping/merchant/reviews/v1): add shopping-merchant-reviews"