Repository navigation
Conversation
…read.sleep Replace CurrentMillisClock and real Thread.sleep delays in DirectRetryingExecutorTest with FakeApiClock and a sleep() override that advances virtual time deterministically. This prevents testMaxRetriesExceeded from flaking with premature totalTimeout expiration on slow CI runners. Fixes googleapis#14625
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request refactors AbstractRetryingExecutorTest and DirectRetryingExecutorTest to use a deterministic FakeApiClock and simulated sleep delays instead of relying on wall-clock pauses, which improves test reliability and execution speed on slow CI environments. The feedback suggests initializing the FakeApiClock with a non-zero value rather than 0L to prevent potential conflicts with internal components that might treat 0L as an uninitialized sentinel value.
lqiu96
marked this pull request as ready for review
October 20, 2026 19:47
lqiu96
added
the
kokoro:force-run
yoshi-kokoro
removed
the
kokoro:force-run
blakeli0
approved these changes
Oct 21, 2026
lqiu96
enabled auto-merge (squash)
October 21, 2026 22:14
lqiu96
disabled auto-merge
October 21, 2026 22:14
lqiu96
enabled auto-merge (squash)
October 21, 2026 22:14
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use FakeApiClock and RecordingScheduler in ScheduledRetryingExecutorTest so non-concurrent retry tests execute deterministically without sleeping. Isolate asynchronous polling and cancellation tests to use per-iteration local ScheduledExecutorService instances and NanoClock. Make RecordingScheduler stubbings lenient to avoid UnnecessaryStubbingException when recorded metrics are not queried.
Fixes #13535