Skip to content

doc(auth): add PQC product neutral guide - #16548

Merged
scotthart merged 2 commits into
googleapis:mainfrom
scotthart:pqc_doc
Oct 7, 2026
Merged

scotthart merged 2 commits into
googleapis:mainfrom
scotthart:pqc_doc

Conversation

@scotthart

Copy link
Copy Markdown
Member

No description provided.

@scotthart
scotthart requested a review from a team as a code owner October 7, 2026 19:18

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces a new product-neutral guide on Post-Quantum Cryptography (PQC) and integrates it into the CMake build configuration. The feedback recommends improving the documentation by updating the code block language identifier from 'c' to 'cpp' for correct syntax highlighting, and replacing the use of 'auto' with an explicit type in the C++ example to align with the repository's style guide regarding obscured return types.

Comment thread doc/product-neutral-guides/post-quantum-cryptography.md Outdated
Comment thread doc/product-neutral-guides/post-quantum-cryptography.md
@codecov

codecov Bot commented Oct 7, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 92.39%. Comparing base (7dc9b68) to head (f1243ee).
⚠️ Report is 4 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #16548      +/-   ##
==========================================
- Coverage   92.41%   92.39%   -0.03%     
==========================================
  Files        2262     2262              
  Lines      218382   218382              
==========================================
- Hits       201819   201771      -48     
- Misses      16563    16611      +48     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@scotthart
scotthart enabled auto-merge (squash) October 7, 2026 19:59
@scotthart
scotthart merged commit bb0deb0 into googleapis:main Oct 7, 2026
71 checks passed

This branch was successfully deployed

1 active deployment
false — f1243ee7 Deployed Oct 7, 2026 by scotthart via Save PR ref #12325
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants