Repository navigation
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
In
fire/formatting_windows.py,initialize_or_disable()referencedsubprocess.STD_OUTPUT_HANDLE. Thesubprocessmodule does not expose this attribute, which leads to anAttributeErrorwhen the Windows 10 native ANSI initialization path executes.This defines the Win32 standard output handle constant
STD_OUTPUT_HANDLE = -11infire/formatting_windows.pyand removes the unusedsubprocessimport.Changes
STD_OUTPUT_HANDLE = -11infire/formatting_windows.pyand passed it tokernel32.GetStdHandle().import subprocessfromfire/formatting_windows.py.fire/formatting_test.pyvalidatingSTD_OUTPUT_HANDLEand verifying the mocked Windows 10 console initialization flow.Fixes #721