docs: Add Sushant Poudel to AUTHORS - #4579
Merged
Merged
Conversation
sushant-me
added a commit
to sushant-me/reputation
that referenced
this pull request
Sep 20, 2026
The go-github Co-authored-by trailer never appeared, and this ledger tracked it as owed. The maintainer has now offered a resolution that fits the repository's squash-merge policy: the contributor opens a PR adding themselves to AUTHORS and records the work in the description. That PR is google/go-github#4579. The evidence claim's negative assertion is unchanged and still checked - a trailer still does not exist - but the claim's wording read as though nothing had happened. It now states the AUTHORS route, and says that when #4579 merges the credit will have landed by a mechanism this claim does not test, so the wording needs revisiting then rather than the check needing to fail. Verified: 19 claims, 15 live, 4 on request, 0 failing; surface checker passes.
gmlewis
changed the title
gmlewis
approved these changes
Sep 20, 2026
gmlewis
left a comment
gmlewis
left a comment
Collaborator
There was a problem hiding this comment.
Thank you, @sushant-me, and apologies for not attributing correctly originally.
LGTM.
Merging.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #4579 +/- ##
=======================================
Coverage 98.59% 98.59%
=======================================
Files 197 197
Lines 18326 18326
=======================================
Hits 18068 18068
Misses 258 258 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this does
Adds one line to
AUTHORS:placed in the file's existing alphabetical position (after
Suhaib Mujahid, beforesushmita wable). The file's own header says:This follows the route you suggested for the squash-merge policy, and I appreciate you offering it rather than leaving it.
The work being credited
I authored #4556, merged on 2026-09-17: a release-asset upload whose URL pointed at a different host than the configured upload host was refused rather than sent with the client's credentials.
You reverted it the next day in favour of your broader #4564, which enforces "credentials are sent only to configured origins" and is what
masterimplements today. That was the right call — #4564 covers the general case rather than the one path #4556 guarded, and #4564 carries the commit "Address feedback from sushant-me" from the review discussion on it.Since the merged commit does not survive in a squash-merge, this entry is the record that the shared-credentials origin check passed through my PR on the way to its present form.
I have also filed four memory-safety issues and two hardening PRs against
google/s2geometry, and MCP tool-shadowing reports against the ADK ports, if a broader list is useful for the file — but this PR adds only my own entry, as you described.Notes
AUTHORSis sorted; the new entry preserves that ordering.Thank you for the review and for the offer.