Skip to content

feat: Add GetBudgetByID function for enterprise budgets - #4565

Draft
wtneff wants to merge 2 commits into
google:masterfrom
wtneff:feature/add-enterprise-budget-function
Draft

wtneff wants to merge 2 commits into
google:masterfrom
wtneff:feature/add-enterprise-budget-function

Conversation

@wtneff

@wtneff wtneff commented Sep 17, 2026

Copy link
Copy Markdown

This PR adds a function to match the getbudgetbyid endpoint in the API for Enterprise Budgets.

Resolves #4408

@google-cla

google-cla Bot commented Sep 17, 2026

Copy link
Copy Markdown

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@wtneff wtneff changed the title feat: Add GetBudgetByID function for enterprise budgets feat: Add GetBudgetByID function for enterprise budgets Sep 17, 2026
@codecov

codecov Bot commented Sep 17, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 98.59%. Comparing base (8d9197f) to head (99545eb).

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #4565   +/-   ##
=======================================
  Coverage   98.59%   98.59%           
=======================================
  Files         197      197           
  Lines       18326    18335    +9     
=======================================
+ Hits        18068    18077    +9     
  Misses        258      258           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@gmlewis gmlewis added NeedsReview PR is awaiting a review before merging. waiting for signed CLA labels Sep 17, 2026
@semioticrobotic

Copy link
Copy Markdown

@gmlewis: I'm assisting @wtneff with this PR. We've each reviewed the CCLA documentation and can confirm we've completed the steps required for passing the CLA checks (we have a signed CCLA in place, @wtneff is a member of the assigned Google Group, etc.). Could you let us know who we can contact for help getting this resolved? I have been sending support requests to the address listed in the documentation (cla-submissions@google.com) for three weeks, but have not received any response. So if you're able to connect us to someone in particular, we'd be most grateful. 🙇

@gmlewis

gmlewis commented Sep 18, 2026

Copy link
Copy Markdown
Collaborator

@gmlewis: I'm assisting @wtneff with this PR. We've each reviewed the CCLA documentation and can confirm we've completed the steps required for passing the CLA checks (we have a signed CCLA in place, @wtneff is a member of the assigned Google Group, etc.). Could you let us know who we can contact for help getting this resolved? I have been sending support requests to the address listed in the documentation (cla-submissions@google.com) for three weeks, but have not received any response. So if you're able to connect us to someone in particular, we'd be most grateful. 🙇

Hi @semioticrobotic - Did you visit the URL: https://cla.developers.google.com/clas with the logged-in user account that signed the commit in this PR (wt...@outlook.com)?

Unfortunately, I no longer have contacts in the Google Open Source team.
But honestly, I've had no reports of problems getting CLAs signed for many years now, so I'm hoping that if all the directions are followed in the "cla/google" link above: https://github.com/google/go-github/pull/4565/checks?check_run_id=105723953055 that you should be able to resolve it.

Please let me know and/or give me screenshots as to what those pages look like or exactly what error messages you are seeing on those web pages, and I will try to help.

@semioticrobotic

Copy link
Copy Markdown

Thanks, @gmlewis, for providing the help you're able to. We're working under an organizational CLA, and I am the designated point of contact. @wtneff is part of our authorized contributor group. Here's what I see when I'm logged in.

Screenshot 2026-09-18 at 3 09 19 PM

We signed a new CCLA earlier this week after attempts to recover the organization's former group failed (could not receive support, as per above). In your experience, how much time must pass before a signed CCLA is deposited and members of the authorized contributor group are able to begin committing successfully?

@gmlewis

gmlewis commented Sep 18, 2026

Copy link
Copy Markdown
Collaborator

We signed a new CCLA earlier this week after attempts to recover the organization's former group failed (could not receive support, as per above). In your experience, how much time must pass before a signed CCLA is deposited and members of the authorized contributor group are able to begin committing successfully?

Ah, OK. Usually group CCLAs are handled within approximately a week, or at least they used to be.

Just make sure to double-check that the "wt...ff@outlook.com" email address matches the one in your Google Group.

Meanwhile, the only remaining contact I have is via @google-admin - can you please look into this CCLA issue?

@semioticrobotic

Copy link
Copy Markdown

Thanks, @gmlewis. We'll keep our fingers crossed that this is still in processing and hope to see some progress next Week. Thanks again for your support.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

NeedsReview PR is awaiting a review before merging. waiting for signed CLA

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add additional functionality for enterprise budgets

3 participants