Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Publish the FlatBuffers npm package with npm provenance.
The existing release job already runs on a GitHub-hosted runner and publishes directly with
npm publish. This change grants only the npm publishing jobid-token: writeand adds--provenance, allowing npm to attach Sigstore-backed provenance to the package while preserving the existing npm token authentication flow.Why
The current npm release has a registry signature but no provenance attestation:
npm provenance gives downstream consumers a verifiable link between the published package, this GitHub repository, and the workflow that built/published it. It complements the registry signature rather than replacing it.
The package metadata already points at
https://github.com/google/flatbuffers.git, which satisfies npm's public-repository requirement for provenance.Scope
publish-npmjobValidation
git diff --check: PASSnpm pack --dry-run --ignore-scripts: PASSflatbuffers@25.12.19flatbuffers-25.12.19.tgzactionlintreports the same pre-existingactions-rs/toolchain@v1obsolete-runner error on both upstreammasterand this branch; this patch introduces no new actionlint finding.npm provenance documentation:
https://docs.npmjs.com/generating-provenance-statements/