Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 6 additions & 5 deletions src/google/adk/evaluation/final_response_match_v2.py
Original file line number Diff line number Diff line change
Expand Up @@ -116,11 +116,12 @@ def _parse_critique(response: str) -> Label:
label = Label.NOT_FOUND
elif label_match_is_response_invalid:
label = label_match_is_response_invalid.group(1).strip().rstrip(",}")
label = (
Label.INVALID
if label in [Label.TRUE.value, Label.INVALID.value]
else Label.VALID
)
if label in [Label.TRUE.value, Label.INVALID.value]:
label = Label.INVALID
elif label in [Label.FALSE.value, Label.VALID.value]:
label = Label.VALID
else:
label = Label.NOT_FOUND
else:
label = Label.NOT_FOUND
return label
Expand Down
31 changes: 31 additions & 0 deletions tests/unittests/evaluation/test_final_response_match_v2.py
Original file line number Diff line number Diff line change
Expand Up @@ -336,6 +336,37 @@ def test_convert_auto_rater_response_to_score_missing_key():
assert auto_rater_score == AutoRaterScore()


@pytest.mark.parametrize(
"label, expected_score",
[
("unknown", None),
("true", 0.0),
("invalid", 0.0),
("false", 1.0),
("valid", 1.0),
],
)
def test_alternate_invalidity_label_requires_a_known_verdict(
label, expected_score
):
"""Unrecognized alternate judge labels do not become passing scores."""
evaluator = _create_test_evaluator_gemini(threshold=0.8)
response = LlmResponse(
content=genai_types.Content(
role="model",
parts=[
genai_types.Part(
text=f'{{"is_the_agent_response_invalid": "{label}"}}'
)
],
)
)

result = evaluator.convert_auto_rater_response_to_score(response)

assert result.score == expected_score


def test_aggregate_per_invocation_samples_none_evaluated():
evaluator = _create_test_evaluator_gemini(threshold=0.5)

Expand Down
Loading