Conversation
On macOS the popup was created at normal window level, so clicking the
tray icon from a fullscreen Space made macOS switch to a Desktop Space
instead of drawing the window over the fullscreen app. Ordinary Desktop
Spaces were unaffected, which is why this only ever reproduced against
fullscreen apps.
electron-menubar elevates the window unconditionally on Windows but
gates it behind the keep-open-on-blur option elsewhere:
if (process.platform === 'win32') win.setAlwaysOnTop(true, 'pop-up-menu');
else win.setAlwaysOnTop(keepOpen || browserWindow.alwaysOnTop === true);
visibleOnFullScreen (which the library already sets) only grants the
window fullScreenAuxiliary collection behavior, letting it join a
fullscreen Space; a normal-level window still cannot render above one.
Opting into alwaysOnTop supplies the missing window level, and the
popup continues to hide on blur, so it floats only while it is open.
Closes gitify-app#563
Author
|
Still need to do some digging. |
Author
|
Closing as this doesn't fix the issue I'm seeing. I'll post a followup comment on #563 with my findings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Clicking the tray icon from a fullscreen Space switched to a Desktop Space instead of drawing the popup over the fullscreen app. Ordinary Desktop Spaces were unaffected, which is why this only reproduced against fullscreen apps.
The cause is window level, not Space membership.
electron-menubarelevates the window unconditionally on Windows, but elsewhere only when the window is kept open on blur:With default settings
keepOpenis false, so the popup sat at normal window level. The library already passesvisibleOnFullScreen, so the window may join a fullscreen Space, but a normal-level window still cannot render above one and macOS switches to a Space where it can. Opting intoalwaysOnTopsupplies the missing level; the popup still hides on blur, so it floats only while open.macOS only. Windows never reads this option, and on Linux an absent key leaves the current
setAlwaysOnTop(false)behavior unchanged — the new test asserts that, and CI runs onubuntu-latest. Verified manually on macOS 27.0 (arm64) with a packaged build; lint, types, and the 1524 unit tests pass, and no renderer markup changed.Fixes #563.