fix: keep glass dropdown options readable on Linux - #3317
Merged
Merged
Conversation
afonsojramos
changed the title
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Glass dropdown options and group labels stay readable in dark mode on Linux. Transparent popup rows could render white behind nearly white text; the fix gives them opaque theme colors while keeping the closed control transparent. The override applies only on Linux, following cross-platform testing that found the issue limited to Linux.
Verified the native popup in Electron 44.1.1 on KDE Wayland. The rebuilt renderer passes light, dark, and System theme checks, and the override stays inactive without the Linux marker and in Classic mode. The production build, lint/format checks, and all 28 targeted appearance tests passed. The pinned arm64 visual regression suite remains for CI on this update because the local machine is x86_64.