Repository navigation
native2: point clicks reach Chrome's vertical tabs under its empty overlay groups (#202) - #222
Merged
Merged
Conversation
iamnbutler
force-pushed
the
fix-chrome-vtabs
branch
from
October 25, 2026 00:18
825ec46 to
f4bfe47
Compare
…erlay groups (#202) Chrome's vertical tab strip lays childless, actionless AXGroups over its tabs. The Accessibility hit test returns one of them, and neither it nor its ancestors can be pressed, so a point click on a tab was refused. When the hit is such an empty group, search its parent's and grandparent's elements at the point (frames checked before children, as for #147) and press the smallest pressable one. Fixes #202 Why: native2/Sources/DesktopMac/Pointer.swift#beneath | Chrome's vertical tab strip covers its tabs with empty AXGroups that the AX hit test returns; only such childless, actionless groups give way to what is beneath
iamnbutler
force-pushed
the
fix-chrome-vtabs
branch
from
October 25, 2026 01:03
f4bfe47 to
f10dfc9
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #202
Root cause. In Chrome 156 with vertical tabs (View > Show Tabs Vertically), each tab is an
AXRadioButton/AXTabButtonwithAXPress, but the strip has childless, actionlessAXGroups laid over it, covering the whole 240×905 strip.AXUIElementCopyElementAtPositionat a tab returns one of those groups. It has no descendants and its ancestors (AXTabGroup, groups, window) have nothing pressable, soclickPointrefused with "No pressable accessibility element was found".Fix (
DesktopMac/Pointer.swift,beneathOverlay/beneath): when the hit is an empty overlay, meaning anAXGroupwith no children and no actions, the point-click candidates also include the pressable elements at the point under its parent, then its grandparent, smallest first. That puts a tab's close button ahead of the tab. They come before the ancestors. The descendant walk still checks frames before reading children (#147).Checked. In a scratch Chrome (
--user-data-dir=/tmp/chrome-b, vertical tabs on), through the standalone host: before, a point click on the "Beta" tab was refused; after, it completes, the window title becomes "Beta - Google Chrome", and Ghostty stays frontmost (background). The same worked for "Gamma". Unit tests are inOverlayClickTests. No recipe needed, since tabs are now clickable by point. Element-ID clicks already worked, because the tabs are listed withAXPress.