fix(events): preserve unowned Vibe hooks files - #4646
Open
WOLIKIMCHENG wants to merge 1 commit into
Open
WOLIKIMCHENG wants to merge 1 commit into
WOLIKIMCHENG wants to merge 1 commit into
Conversation
Avoid rewriting or deleting hooks.toml when cleanup finds no Spec Kit-managed hooks to remove. Preserve existing cleanup behavior for managed entries.
mnriem
added
the
triage-nice-to-have
Contributor
There was a problem hiding this comment.
Copilot review overview
🟢 Approval recommended
The focused fix is correct and has comprehensive regression coverage.
Review effort: Balanced
Findings: None
What changed in this PR
Preserves unowned Vibe hook configuration during no-op cleanup.
Changes:
- Skips rewriting when no Spec Kit hook is removed.
- Adds regression coverage for content, timestamps, comments, whitespace, and forced teardown.
| File | Description |
|---|---|
src/specify_cli/events.py |
Adds the no-op cleanup guard. |
tests/integrations/test_events.py |
Tests preservation of unowned Vibe files. |
💡 Configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Preserve existing
.vibe/hooks.tomlfiles when Vibe cleanup finds noSpec Kit-managed hooks to remove.
This prevents no-op installation and teardown paths from rewriting user
content, changing line endings, or deleting comment-only and whitespace-only
files. Cleanup of Spec Kit-managed hooks remains unchanged.
Testing
git diff --check: passedAI Disclosure
AI disclosure: OpenAI Codex (GPT-5.6 Sol, Terra, and Luna;
human-supervised) assisted with code and tests.