Repository navigation
Respect textarea editability before applying formatting - #116
Open
feritcemkahraman wants to merge 1 commit into
Open
feritcemkahraman wants to merge 1 commit into
feritcemkahraman wants to merge 1 commit into
Conversation
There was a problem hiding this comment.
🟢 Approval recommended
The focused guard and regression tests cover the intended restrictions and recovery behavior without unresolved issues.
No open issues 🎉
What changed in this PR
Prevents toolbar formatting from modifying textareas that are not editable.
Changes:
- Guard formatting for readonly, disabled, and fieldset-disabled textareas.
- Add regressions verifying unchanged values, no input events, and normal formatting after re-enabling.
| File | Description |
|---|---|
| test/test.js | Tests all three restrictions and recovery. |
| src/index.ts | Checks editability before applying formatting. |
Review effort: Max
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Formatting buttons can change a readonly or disabled textarea, including one disabled by its surrounding fieldset. This also emits an input event even though the field is not editable.
Check the field's readonly and native disabled states before applying formatting. The regressions verify that restricted fields keep their value and emit no input event, then format normally again when enabled.
Validation: all three regressions failed before the fix; all 147 Chromium tests now pass through the repository's Karma runner. The TypeScript distribution/declaration build and full configured ESLint check pass using the installed lockfile dependencies on Node 24. The Windows cleanup wrapper was bypassed by running the same tools directly; Firefox and WebKit were not run.