Conversation
Contributor
There was a problem hiding this comment.
Copilot review overview
🟢 Approval recommended
The focused implementation is consistent with the extracted AST shape and is covered by an appropriate regression test.
Review effort: Balanced
Findings: None
What changed in this PR
Extends unified static name binding to resolve members accessed through Swift generic type expressions.
Changes:
- Unwraps
GenericTypeExprto its base identifier during reference resolution. - Adds coverage for inferred and explicitly specialized generic enum access.
| File | Description |
|---|---|
unified/ql/lib/codeql/unified/internal/StaticNameBinding.qll |
Resolves generic type bases during static binding. |
unified/ql/test/library-tests/static-name-binding/generics.swift |
Tests generic enum and member resolution. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
hvitved
force-pushed
the
unified/static-name-binding-generic-type-expr
branch
from
September 23, 2026 13:05
a95acc1 to
009d0c3
Compare
hvitved
marked this pull request as ready for review
September 23, 2026 13:06
asgerf
reviewed
Sep 23, 2026
Co-authored-by: Asger F <asgerf@github.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Extracted from #22639.