Skip to content

unified: Configure vscode Swift extension - #22635

Merged
asgerf merged 2 commits into
github:mainfrom
asgerf:unified/vscode-config
Sep 21, 2026
Merged

asgerf merged 2 commits into
github:mainfrom
asgerf:unified/vscode-config

Conversation

@asgerf

@asgerf asgerf commented Sep 21, 2026

Copy link
Copy Markdown
Contributor

Adds files to make the vscode Swift extension work when editing test cases.

Adds files to make the vscode Swift extension work when editing test cases.
@asgerf asgerf added the no-change-note-required This PR does not need a change note label Sep 21, 2026
@asgerf
asgerf requested a balanced review from Copilot September 21, 2026 09:17

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot review overview

🟡 Changes recommended

The workspace does not select the extractor’s pinned Swift toolchain, allowing incorrect fixture diagnostics and formatting.

Get a fresh assessment by requesting another Copilot review.

Review effort: Balanced
Findings: 1 Medium severity

Open (1)
What changed in this PR

Configures Swift tooling for editing unified extractor fixtures in VS Code.

Changes:

  • Adds a targetless Swift package.
  • Recommends and configures the Swift extension.
  • Ignores SwiftPM build output.
File Description
unified/​Package.swift Defines the editor-facing Swift package.
unified/​.vscode/​settings.json Configures Swift extension behavior and formatting.
unified/​.vscode/​extensions.json Recommends the Swift extension.
unified/​.gitignore Ignores .build output.

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Comment thread unified/Package.swift Outdated
@asgerf
asgerf marked this pull request as ready for review September 21, 2026 09:29
@asgerf
asgerf requested a review from a team as a code owner September 21, 2026 09:29
Sync'ing on a single source of truth would be nice but is too invasive right now
@asgerf
asgerf merged commit e258ded into github:main Sep 21, 2026
7 checks passed

@Kamil-0425 Kamil-0425 left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hej

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

no-change-note-required This PR does not need a change note

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants