Repository navigation
Graduate overlay-aware CodeQL version selection - #4246
Open
henrymercer wants to merge 3 commits into
Open
henrymercer wants to merge 3 commits into
henrymercer wants to merge 3 commits into
Conversation
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
Warning
- Copilot's review of this pull request may be incomplete because some of the changed files are excluded by your Copilot content exclusion settings. See Excluding content from Copilot for details.
🔵 Needs a closer look
A maintainer should confirm rollout readiness before removing the feature-flag kill switch.
1 open finding
What changed in this PR
Graduates overlay-aware default CodeQL version selection for eligible Code Scanning pull requests.
Changes:
- Removes feature flags, dry-run behavior, and diagnostic telemetry.
- Skips cache lookup on GHES and when only one default version is enabled.
- Updates regression coverage for selection eligibility.
| File | Description |
|---|---|
| src/setup-codeql.ts | Graduates selection and adds cache-lookup guards. |
| src/setup-codeql.test.ts | Covers supported environments and bypass conditions. |
| src/feature-flags.ts | Removes selection and dry-run flags. |
Files excluded by content exclusion policy (1)
- lib/entry-points.js
🧠 Review effort: Max
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
henrymercer
marked this pull request as ready for review
October 16, 2026 14:08
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Graduate
overlay_analysis_match_codeql_versionand remove theoverlay_analysis_match_codeql_version_dry_rundry run, along with the telemetry diagnostic added for it. GHES is excluded explicitly since there are no feature flags and therefore only one CodeQL version will ever be enabled there. Also, as a small optimisation, skip listing the Actions cache when only one default CodeQL version is enabled, since there is only one CodeQL version to choose in this case.Risk assessment
For internal use only. Please select the risk level of this change:
Which use cases does this change impact?
Workflow types:
dynamicworkflows (Default Setup, Code Quality, ...).Products:
analysis-kinds: code-scanning.Environments:
github.comand/or GitHub Enterprise Cloud with Data Residency.How did/will you validate this change?
.test.tsfiles).If something goes wrong after this change is released, what are the mitigation and rollback strategies?
How will you know if something goes wrong after this change is released?
Are there any special considerations for merging or releasing this change?
Merge / deployment checklist