Fix path-resolution bug in changenotes.mts validate by using getChangenotes - #4156
Open
mario-campos wants to merge 1 commit into
Open
mario-campos wants to merge 1 commit into
mario-campos wants to merge 1 commit into
Conversation
mario-campos
force-pushed
the
mario-campos/fix-validate-cmd
branch
from
September 18, 2026 20:09
fc0dbb2 to
dedce4e
Compare
changenotes.mts validate commandchangenotes.mts validate by using getChangenotes
mario-campos
force-pushed
the
mario-campos/fix-validate-cmd
branch
2 times, most recently
from
September 22, 2026 13:14
bf6da6f to
609b22f
Compare
mario-campos
force-pushed
the
mario-campos/fix-validate-cmd
branch
from
September 22, 2026 13:17
609b22f to
e1b1575
Compare
This reduces duplicate code between `assemble` and `validate`. It also has the benefit of fixing a bug in the current implementation of `validate`, where `isValidChangenoteFile` receives a relative file name where it should receive an absolute one.
mario-campos
force-pushed
the
mario-campos/fix-validate-cmd
branch
from
September 22, 2026 14:01
e1b1575 to
738bd62
Compare
mario-campos
marked this pull request as ready for review
September 22, 2026 14:16
Contributor
There was a problem hiding this comment.
Copilot review overview
🟢 Approval recommended
The focused change correctly fixes working-directory-dependent path resolution without leaving unresolved usages.
Review effort: Balanced
Findings: None
What changed in this PR
Fixes changenote validation from arbitrary working directories by validating repository-rooted paths.
Changes:
- Uses
getChangenotes()to resolve changenote paths. - Removes the obsolete aggregate validator and its tests.
| File | Description |
|---|---|
pr-checks/changenotes.mts |
Validates changenotes using resolved paths. |
pr-checks/changelog/validate.mts |
Removes the unused aggregate validator. |
pr-checks/changelog/validate.test.mts |
Removes tests for the deleted helper. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
isValidChangenoteFilereceives a file name (no leading path) and then attempts to read that file, regardless of the CWD. If the user's CWD is not inunreleased-change-notes, then the command will likely fail to open the file.Incidentally, for #4155, I've added
getChangenotes, which consolidates some duplicative code between theassembleandvalidatecommands. We can take advantage of that here invalidate, and in so doing, fix the bug.Risk assessment
For internal use only. Please select the risk level of this change:
Which use cases does this change impact?
Workflow types:
Products:
Environments:
How did/will you validate this change?
.test.tsfiles).If something goes wrong after this change is released, what are the mitigation and rollback strategies?
How will you know if something goes wrong after this change is released?
Are there any special considerations for merging or releasing this change?
Merge / deployment checklist