Skip to content

[Outreachy PATCH] t2403: modernize test for directory existence - #2259

Open
shashu8660 wants to merge 1 commit into
gitgitgadget:masterfrom
shashu8660:outreachy1
Open

shashu8660 wants to merge 1 commit into
gitgitgadget:masterfrom
shashu8660:outreachy1

Conversation

@shashu8660

@shashu8660 shashu8660 commented Oct 15, 2026 •

Copy link
Copy Markdown

CC: Kaartic Sivaraam kaartic.sivaraam@gmail.com, Christian Couder christian.couder@gmail.com, Siddharth Asthana siddharthasthana31@gmail.com, Usman Akinyemi usmanakinyemi202@gmail.com, Junio C Hamano gitster@pobox.com

Replace the old-style shell `test -d` commands with Git's modern
`test_path_is_dir` helper function.

This provides better debugging output if the tests were to fail,
as the helper prints a clear error message rather than just failing
silently like `test -d` does.

Signed-off-by: Shashank <shashu8660@gmail.com>
@shashu8660

Copy link
Copy Markdown
Author

/preview

@gitgitgadget

gitgitgadget Bot commented Oct 15, 2026

Copy link
Copy Markdown

Preview email sent as pull.2259.git.1792098419288.gitgitgadget@gmail.com

@shashu8660

Copy link
Copy Markdown
Author

/submit

@gitgitgadget

gitgitgadget Bot commented Oct 16, 2026

Copy link
Copy Markdown

Submitted as pull.2259.git.1792125111461.gitgitgadget@gmail.com

To fetch this version into FETCH_HEAD:

git fetch https://github.com/gitgitgadget/git/ pr-2259/shashu8660/outreachy1-v1

To fetch this version to local tag pr-2259/shashu8660/outreachy1-v1:

git fetch --no-tags https://github.com/gitgitgadget/git/ tag pr-2259/shashu8660/outreachy1-v1

@gitgitgadget

gitgitgadget Bot commented Oct 18, 2026

Copy link
Copy Markdown

This patch series was integrated into seen via git@c645a5d.

@gitgitgadget gitgitgadget Bot added the seen label Oct 18, 2026
@gitgitgadget

gitgitgadget Bot commented Oct 19, 2026

Copy link
Copy Markdown

This branch is now known as ss/t2403-modernize-test-d.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant