Conversation
Author
|
/cc Nikita Makarov n.makarov@yadro.com |
|
User |
spkrka
force-pushed
the
krka/line-range-trailing-blank
branch
2 times, most recently
from
September 21, 2026 10:47
7fd6178 to
40609b2
Compare
git log -L :funcname: includes trailing empty lines in the
function range. This boils down to parse_range_funcname()
extending the range forward until it either reaches end-of-file
or another function, without skipping empty lines at the
boundary. Including empty lines is inconsistent with how it
works for git grep -W.
Fix this by trimming trailing empty lines from the computed range,
with the same goal as this fix (though with a different approach):
8e5dd94 (grep: -W: skip trailing empty lines at EOF, too,
2024-07-30)
Reported-by: Nikita Makarov <n.makarov@yadro.com>
Signed-off-by: Kristofer Karlsson <krka@spotify.com>
spkrka
force-pushed
the
krka/line-range-trailing-blank
branch
from
September 21, 2026 10:51
40609b2 to
f2e217d
Compare
Author
|
/submit |
|
Submitted as pull.2234.git.1789991377413.gitgitgadget@gmail.com To fetch this version into To fetch this version to local tag |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
cc: René Scharfe l.s.r@web.de
cc: Nikita Makarov n.makarov@yadro.com