Skip to content

Prepare manual npm Trusted Publishing with OIDC - #2

Merged
gitdamnit merged 1 commit into
mainfrom
chore/npm-oidc-manual-publishing
Oct 30, 2026
Merged

gitdamnit merged 1 commit into
mainfrom
chore/npm-oidc-manual-publishing

Conversation

@gitdamnit

Copy link
Copy Markdown
Owner

What changes

  • Publish only on manual workflow dispatch; never on GitHub release or tag push.
  • Require a stable release tag and verify it matches package.json.
  • Check out that exact tag so publication never accidentally uses the current default branch.
  • Use GitHub-hosted Node 24, npm 11, and OIDC (id-token: write) instead of permanent NPM_TOKEN credentials.
  • Preserve existing build/test checks before publishing.

Safety / approval

This PR does not publish anything. Do not run the manual publishing workflow until the npm package's Trusted Publisher has been configured for this exact GitHub repository and publish.yml, and the maintainer separately approves publishing. For @gitdamnit/stranger-danger (not yet on npm), an initial authenticated bootstrap publication is required before npm will let us establish trust.

Review

Confirm workflows pass GitHub YAML/action validation, source tag is the released artifact, and npm ownership / OIDC prerequisites are satisfied before merge.

@gitdamnit
gitdamnit marked this pull request as ready for review October 30, 2026 00:03
@gitdamnit
gitdamnit merged commit aa2d8b6 into main Oct 30, 2026
3 checks passed
@gitdamnit
gitdamnit deleted the chore/npm-oidc-manual-publishing branch October 30, 2026 00:03
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 30, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-30T00:05:19.917756Z 7a8f97a Draft marked ready
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant