Skip to content

CONTRIBUTING.md: recommend shallow threading of cover letters - #6429

Merged
dscho merged 1 commit into
git-for-windows:mainfrom
taahol:ta/contributing-md-shallow-threads
Sep 26, 2026
Merged

dscho merged 1 commit into
git-for-windows:mainfrom
taahol:ta/contributing-md-shallow-threads

Conversation

@taahol

@taahol taahol commented Sep 21, 2026

Copy link
Copy Markdown

No description provided.

Comment thread CONTRIBUTING.md Outdated
Comment thread CONTRIBUTING.md
```
git send-email --to=git@vger.kernel.org --cc=<email1> --cc=<email2> \
--in-reply-to=<the message id of cover letter of patch v2> [dir with patches]/*.patch
--in-reply-to=<the message id of cover letter of patch v1> [dir with patches]/*.patch

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why?

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It’s all in the commit message: to match 16b2924.

The upstream Git project changed the guidance in 16b2924
(MyFirstContribution: recommend shallow threading of cover
letters, 2026-06-15) to prefer arrangement where all cover
letters are direct replies to the v1 cover letter.

Update CONTRIBUTING.md to reflect that.

Signed-off-by: Tuomas Ahola <taahol@utu.fi>
@taahol
taahol force-pushed the ta/contributing-md-shallow-threads branch from 1b58658 to aef938a Compare September 24, 2026 10:19
@taahol

taahol commented Sep 24, 2026

Copy link
Copy Markdown
Author
1:  1b586585f5e ! 1:  aef938aebf5 fixup! CONTRIBUTING.md: add guide for first-time contributors
    @@ Commit message
     
         Update CONTRIBUTING.md to reflect that.
     
    -    While at it, replace (at times unresponsive) public-inbox.org
    -    links with links to lore.kernel.org.
    -
         Signed-off-by: Tuomas Ahola <taahol@utu.fi>
     
      ## CONTRIBUTING.md ##
    -@@ CONTRIBUTING.md: you can fix quickly, or if anything catches your eye.
    - 
    - You can also look at [the unofficial Chromium issues page](https://crbug.com/git) for
    - multi-platform issues. You can look at recent user questions on
    --[the Git mailing list](https://public-inbox.org/git).
    -+[the Git mailing list](https://lore.kernel.org/git).
    - 
    - Or you can "scratch your own itch", i.e. address an issue you have with Git. The team at Microsoft where the Git for Windows maintainer works, for example, is focused almost entirely on [improving performance](https://blogs.msdn.microsoft.com/devops/2018/01/11/microsofts-performance-contributions-to-git-in-2017/).
    - We approach our work by finding something that is slow and try to speed it up. We start our
    -@@ CONTRIBUTING.md: Submit Your Patch
    - 
    - Git for Windows [accepts pull requests on GitHub](https://github.com/git-for-windows/git/pulls), but
    - these are reserved for Windows-specific improvements. For core Git, submissions are accepted on
    --[the Git mailing list](https://public-inbox.org/git).
    -+[the Git mailing list](https://lore.kernel.org/git).
    - 
    - ### Configure Git to Send Emails
    - 
     @@ CONTRIBUTING.md: To construct a patch set, use the `git format-patch` command. There are three im
        `git branch --edit-description`, you will end up with a 0/N mail with that description and
        a nice overall diffstat.
      * `--in-reply-to=[Message-ID]`: This will mark your cover letter as replying to the given
     -  message (which should correspond to your previous iteration). To determine the correct Message-ID,
    --  find the message you are replying to on [public-inbox.org/git](https://public-inbox.org/git) and take
     +  message (which should correspond to your first iteration). To determine the correct Message-ID,
    -+  find the message you are replying to on [lore.kernel.org/git](https://lore.kernel.org/git) and take
    +   find the message you are replying to on [public-inbox.org/git](https://public-inbox.org/git) and take
        the ID from between the angle brackets.
      
    - * `--subject-prefix=[prefix]`: This defaults to [PATCH]. For subsequent iterations, you will want to
     @@ CONTRIBUTING.md: To submit a nth version patch (say version 3):
      
      ```

@dscho dscho left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for taking my feedback, and for clarifying the change I didn't immediately understand.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants