Repository navigation
fix(signing): include repeated header values - #47
Open
bensynapse wants to merge 1 commit into
Open
bensynapse wants to merge 1 commit into
bensynapse wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I run Live Tennis API.
Requests signed with repeated headers currently fail authentication because the signing message includes only the first value. For example, two Cache-Control fields should produce
cache-control: max-age=60, must-revalidate.The signing message now joins header values in transmitted order with comma and space. This follows the draft's signature string rules.
Nine string cases and six real HTTP cases pass. Ten cases fail against the original code, including four HTTP requests that return 401 instead of 204.
The CI command
go test -v -covermode=atomic -coverprofile=coverage.outpasses on Go 1.26.0 and 1.27.1. Both versions also passgo test -race ./...,go build ./...andgo vet ./.... The fullmake testcommand passes in the Go 1.26.3 container.make install-tools lintreports zero issues.