Skip to content

ci(ios): Archive the SwiftPM app to catch xcframework signature collisions - #6871

Merged
alwx merged 1 commit into
mainfrom
alwx/ci/spm-archive
Oct 12, 2026
Merged

alwx merged 1 commit into
mainfrom
alwx/ci/spm-archive

Conversation

@alwx

@alwx alwx commented Oct 12, 2026

Copy link
Copy Markdown
Contributor

📢 Type of change

  • Enhancement

📜 Description

The SwiftPM CI job now archives the app for iOS devices in the production matrix entry. The job then makes sure that the archive contains the app binary and the Sentry.xcframework signature.

💡 Motivation and Context

Only the archive step collects xcframework signatures into Signatures/. If two targets supply the Sentry signature, the archive fails, but a plain build passes. Users found this collision in the old SENTRY_USE_SPM=1 path (see the comment in #6174), and CI did not test it for the SwiftPM autolinking path from #6784.

💚 How did you test it?

I did the CI steps locally with React Native 0.87.1 and Xcode 26.1. The archive passed, and Xcode collected the Sentry signature one time.

📝 Checklist

  • No new PII added or SDK only sends newly added PII if sendDefaultPII is enabled.
  • No breaking changes.

🤖 Generated with Claude Code

…sions

The archive step collects xcframework signatures into `Signatures/`. A
second copy of the Sentry signature fails the archive, and a plain build
does not show this.

Co-Authored-By: Claude <noreply@anthropic.com>
@github-actions

github-actions Bot commented Oct 12, 2026 •

Copy link
Copy Markdown
Contributor

Semver Impact of This PR

⚪ None (no version bump detected)

📋 Changelog Preview

This is how your changes will appear in the changelog.
Entries from this PR are highlighted with a left border (blockquote style).


  • ci(ios): Archive the SwiftPM app to catch xcframework signature collisions by alwx in #6871
  • feat(core): Support applicationKey and moduleMetadata in Metro config by alwx in #6863
  • chore(deps): update JavaScript SDK to v10.76.2 by antonis in #6866
  • ci(core): Guard the "sideEffects": false contract with a lint check by antonis in #6836
  • chore(deps): bump nx from 22.7.7 to 22.7.12 by dependabot in #6857
  • chore(deps): bump compression from 1.7.5 to 1.8.2 by dependabot in #6856
  • chore(deps): bump postcss-selector-parser from 7.1.4 to 7.1.6 by dependabot in #6855
  • chore(deps): bump source-map-js from 1.2.1 to 1.2.2 by dependabot in #6854
  • chore(deps): bump proxy-addr from 2.0.7 to 2.0.8 by dependabot in #6853
  • chore(deps): bump handlebars from 4.7.9 to 4.7.10 by dependabot in #6862
  • chore(deps): update Wizard to v8.0.1 by github-actions in #6852

🤖 This preview updates automatically when you update the PR.

@alwx
alwx marked this pull request as ready for review October 12, 2026 11:53

@antonis antonis left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM once the CI is 🟢

@antonis antonis added the ready-to-merge Triggers the full CI test suite label Oct 12, 2026
@alwx
alwx merged commit 118dddb into main Oct 12, 2026
119 of 138 checks passed
@alwx
alwx deleted the alwx/ci/spm-archive branch October 12, 2026 12:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready-to-merge Triggers the full CI test suite

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants