Repository navigation
feat: Rename diagnostic_channel, fetch and gRPC span origins - #25601
Merged
Merged
Conversation
Drop the suffix from the graphql origin (`auto.graphql`), since there is only one graphql instrumentation path. For redis, mysql2 and mongoose, rename it to `native_channel` to make clear these spans come from the library's own tracing channels rather than orchestrion-injected ones. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Contributor
size-limit report 📦Compared: ab3cfd2 (PR test merge using develop at a01cfca) Against: a01cfca (develop) · base run #62876 ✅ Baseline matches: this diff contains only this PR's changes.
|
- auto.http.wintercg_fetch -> auto.http.fetch, matching the Bun, Deno and Cloudflare fetch integrations. - auto.grpc.serverless -> auto.grpc.google_cloud, naming the integration. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
mydea
changed the title
diagnostic_channel span originsdiagnostic_channel, fetch and gRPC span origins
mydea
changed the title
diagnostic_channel, fetch and gRPC span originsdiagnostic_channel, fetch and gRPC span origins
Keep the integration name in the origin, like every other integration (`auto.<category>.<integration>`). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
mydea
marked this pull request as ready for review
October 21, 2026 10:42
mydea
requested review from
andreiborza and
isaacs
and removed request for
a team
October 21, 2026 10:42
isaacs
approved these changes
Oct 21, 2026
mydea
changed the title
diagnostic_channel, fetch and gRPC span originsdiagnostic_channel, fetch and gRPC span origins
51 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
.diagnostic_channelsuffix on span origins was left over from v10, where it distinguished these spans from the OTel-based ones. The rest of the v11 origins already dropped mechanism parts like.oteland.orchestrion.auto.graphql.diagnostic_channel→auto.graphql.graphql: graphql has a single instrumentation path, so the suffix carried no information. The integration name stays, as in every otherauto.<category>.<integration>origin.auto.db.{redis,mysql2,mongoose}.diagnostic_channel→auto.db.{redis,mysql2,mongoose}.native_channel: these integrations still have two paths, the library's own tracing channels (newer versions) and orchestrion-injected channels (older versions, plainauto.db.<lib>).native_channelsays what the distinction actually is.While at it, two origins that were inconsistent with their siblings:
auto.http.wintercg_fetch→auto.http.fetch: Bun, Deno and Cloudflare already useauto.http.fetchfor the same instrumentation.auto.grpc.serverless→auto.grpc.google_cloud:serverlessdidn't name the integration.Spec violations (category, part count) are handled separately in #25602.
🤖 Generated with Claude Code