Skip to content

feat(core): Support SuppressedError in LinkedErrors integration - #25246

Open
kunal649 wants to merge 2 commits into
getsentry:developfrom
kunal649:kunal/feat/support-suppressed-error
Open

kunal649 wants to merge 2 commits into
getsentry:developfrom
kunal649:kunal/feat/support-suppressed-error

Conversation

@kunal649

Copy link
Copy Markdown

SuppressedError is what JS throws when a cleanup (using / Symbol.dispose) fails while another error is already in flight. It keeps both errors, error (the new one) and suppressed (the original), and it has no cause. because of that, LinkedErrors never saw them. In Sentry I only got the generic wrapper message, "An error was suppressed during disposal".
Take a look , how it looks today (node SDK):

Screenshot 2026-10-11 195752

This change makes aggregateExceptionsFromError also follow error and suppressed, the same way it already follows cause and errors[], both errors now show up as chained exceptions. If a SuppressedError has another SuppressedError inside, it goes down the chain too.

And one thing I'm not sure about: I did not set is_exception_group on the wrapper. From #10850 i understand that flag makes sentry ignore that entry for grouping and titles, and that was a problem for cause errors. But the wrapper here has a meaningless message, so maybe it should be a group. (happy to change it if you prefer.)

I added tests for both errors, nested SuppressedErrors, non-Error values, and an error that only has an error property (it must not be treated as a SuppressedError).

Fixes #8441

@github-actions github-actions Bot added the external PR from an external contributor label Oct 11, 2026

@cursor cursor Bot left a comment •

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Stale Bugbot comment from a previous run.

});

expect(event.exception?.values).toHaveLength(1);
});

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Feat lacks integration coverage

Medium Severity

This feat only adds unit tests around applyAggregateErrorsToEvent with a fake SuppressedError. The testing conventions require at least one integration or E2E test for feat PRs. An end-to-end captureException case with a native SuppressedError, matching the existing AggregateError suites, is missing.

Fix in Cursor Fix in Web

Triggered by project rule: PR Review Guidelines for Cursor Bot

Reviewed by Cursor Bugbot for commit 1834d47. Configure here.

@timfish

timfish commented Oct 12, 2026

Copy link
Copy Markdown
Collaborator

Hey @kunal649 thanks for the PR. Looks good!

Can you add an integration test with using that's gated to Node v22 like this.

@JPeer264
JPeer264 requested review from JPeer264 and timfish October 12, 2026 12:24

@cursor cursor Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

There are 2 total unresolved issues (including 1 from previous review).

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit 91c0b88. Configure here.

);
}
});
}

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Feat is missing an integration test

Medium Severity

Flagged because the review rules require feat PRs to include an integration or E2E test. Coverage here is unit-only via FakeSuppressedError, so native using / SuppressedError never runs through LinkedErrors. A Node test gated with test.runIf(supports({ min: 22 })) would close that gap.

Fix in Cursor Fix in Web

Triggered by project rule: PR Review Guidelines for Cursor Bot

Reviewed by Cursor Bugbot for commit 91c0b88. Configure here.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

external PR from an external contributor

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Handle SuppressedError

2 participants