Repository navigation
test(spring): [Sample Tests 28] Move the Spring 7 WAR sample's tests into the module - #6320
Draft
runningcode wants to merge 1 commit into
Draft
runningcode wants to merge 1 commit into
runningcode wants to merge 1 commit into
Conversation
This was referenced Oct 20, 2026
Merged
Merged
Merged
Merged
Draft
📲 Install BuildsAndroid
|
4 of 9 tasks
This was referenced Oct 20, 2026
Open
runningcode
force-pushed
the
no/spring-7-integration-test
branch
from
October 21, 2026 09:19
cd8325f to
d5e9509
Compare
runningcode
force-pushed
the
no/spring-jakarta-integration-test
branch
from
October 21, 2026 11:27
0fb9338 to
e7c763d
Compare
runningcode
force-pushed
the
no/spring-7-integration-test
branch
from
October 21, 2026 11:27
d5e9509 to
c5ff6d9
Compare
runningcode
force-pushed
the
no/spring-jakarta-integration-test
branch
from
October 22, 2026 12:40
e7c763d to
7a49f3f
Compare
runningcode
force-pushed
the
no/spring-7-integration-test
branch
2 times, most recently
from
October 22, 2026 13:31
62a525b to
546e793
Compare
runningcode
force-pushed
the
no/spring-jakarta-integration-test
branch
from
October 22, 2026 13:31
7a49f3f to
3bda1fb
Compare
runningcode
force-pushed
the
no/spring-7-integration-test
branch
2 times, most recently
from
October 22, 2026 16:02
4bd1f5c to
ce8c40d
Compare
runningcode
force-pushed
the
no/spring-jakarta-integration-test
branch
from
October 23, 2026 08:24
4e8a1b6 to
e0ed9f7
Compare
runningcode
force-pushed
the
no/spring-7-integration-test
branch
from
October 23, 2026 08:24
ce8c40d to
2d20815
Compare
runningcode
force-pushed
the
no/spring-jakarta-integration-test
branch
from
October 23, 2026 08:58
e0ed9f7 to
ea67b1c
Compare
runningcode
force-pushed
the
no/spring-7-integration-test
branch
from
October 23, 2026 08:58
2d20815 to
38e9173
Compare
runningcode
force-pushed
the
no/spring-jakarta-integration-test
branch
from
October 23, 2026 09:35
ea67b1c to
b9e7e47
Compare
runningcode
force-pushed
the
no/spring-7-integration-test
branch
from
October 23, 2026 09:35
38e9173 to
84b5a63
Compare
runningcode
force-pushed
the
no/spring-jakarta-integration-test
branch
from
October 23, 2026 11:51
b9e7e47 to
44f206d
Compare
runningcode
force-pushed
the
no/spring-7-integration-test
branch
2 times, most recently
from
October 23, 2026 12:48
15246a5 to
82f9173
Compare
runningcode
force-pushed
the
no/spring-jakarta-integration-test
branch
2 times, most recently
from
October 23, 2026 13:02
561c71a to
ffb52b3
Compare
runningcode
force-pushed
the
no/spring-7-integration-test
branch
from
October 23, 2026 13:02
82f9173 to
840a54e
Compare
runningcode
force-pushed
the
no/spring-jakarta-integration-test
branch
from
October 23, 2026 13:53
ffb52b3 to
e58562e
Compare
runningcode
force-pushed
the
no/spring-7-integration-test
branch
from
October 23, 2026 13:53
840a54e to
1acad11
Compare
Adds sentry-spring-jakarta's embedded-Tomcat integrationTest suite to sentry-spring-7, with the module's packages. The sample's tests were the jakarta WAR sample's, so the suite is too. Spring Boot 4's BOM picks Spring 7 and Tomcat 11. The sample has no system tests left, so it comes off the system-test runner, the backend workflow and the Spring Boot 4 matrix. That was the matrix's last runner step, so it drops the Python setup and the runner's logs too. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
runningcode
force-pushed
the
no/spring-7-integration-test
branch
from
October 23, 2026 15:10
1acad11 to
f9b8fdc
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Stack (Sample Tests)
main)📜 Description
Adds #6319's embedded-Tomcat
integrationTestsuite tosentry-spring-7, withio.sentry.spring7's packages.sentry-samples-spring-7's tests match the jakarta WAR sample's except for the URL, so the suite does too:http.servertransaction and the logs;Spring Boot 4's BOM picks Spring 7 and Tomcat 11. As in #6319, Spring Boot itself stays off the suite's classpath, so Sentry's servlet container initializer takes its WAR path and adds
SentrySpringFilter.With no system tests left, the sample comes off the runner, the backend workflow and the Spring Boot 4 matrix. That was the matrix's last runner step, so the matrix also drops the Python setup,
SENTRY_URLand the runner's log uploads.💡 Motivation and Context
Plain Spring 7, without Boot, now runs end to end in the module. The suite runs 5 tests in a few seconds.
💚 How did you test it?
:sentry-spring-7:checkpasses, and the sample's WAR still builds.📝 Checklist
sendDefaultPIIis enabled.🔮 Next steps
The
sentry-spring(javax) WAR sample.#skip-changelog
🤖 Generated with Claude Code