Repository navigation
Conversation
…arrays Failed-request detection in the Apollo 3, 4, and 5 integrations matched any `errors` array, including an empty one, which produced false-positive events. Only match an `errors` array with at least one entry. Fixes #6194
📲 Install BuildsAndroid
|
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📜 Description
Failed-request detection in the Apollo 3, 4, and 5 integrations now only captures an event when the GraphQL
errorsarray contains at least one entry. Previously the matcher only checked for the opening bracket of anerrorsarray, so a response like{"data": {}, "errors": []}produced a false-positive event.The detection stays regex-based (
"errors"\s*:\s*\[\s*[^\]\s]), tolerant of whitespace and line breaks. Body reading, streaming-response handling, and data collection are unchanged.Known limitation, unchanged by this PR: a non-empty field named
errorsnested insidedatastill matches.💡 Motivation and Context
Follow-up from #6074 (comment)
💚 How did you test it?
errorsarray and verifies no event is captured. The tests failed before the fix because an event was captured.errorsarray continue to verify capture.{"errors":[]}to a non-empty array, since those tests expect a capture../gradlew :sentry-apollo-3:check :sentry-apollo-4:check :sentry-apollo-5:check📝 Checklist
sendDefaultPIIis enabled.🔮 Next steps