Skip to content

Fix JDK 21 findings in sentry-android-core #6261

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
markushi wants to merge 1 commit into
base: build/jdk-21
Choose a base branch
from
Open

Fix JDK 21 findings in sentry-android-core #6261

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions sentry-android-core/src/main/java/io/sentry/android/core/ApplicationNotResponding.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,8 @@
final class ApplicationNotResponding extends RuntimeException {
private static final long serialVersionUID = 252541144579117016L;

// temp fix for JDK 21: Never serialized.
@SuppressWarnings("serial")
private final @Nullable Thread thread;

ApplicationNotResponding(final @Nullable String message) {
Expand Down
3 changes: 3 additions & 0 deletions sentry-android-core/src/main/java/io/sentry/android/core/SentryUserFeedbackButton.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,9 @@
/**
* @deprecated `SentryUserFeedbackButton` will be removed in the next major version
*/
// temp fix for JDK 21: Constructors call overridable methods; making them final would break the
// public API.
@SuppressWarnings("this-escape")
@Deprecated
public class SentryUserFeedbackButton extends Button {

Expand Down
3 changes: 3 additions & 0 deletions sentry-android-core/src/main/java/io/sentry/android/core/performance/AppStartMetrics.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,6 +50,9 @@
* <p>This class is also responsible for - determining the app start type (cold, warm) - determining
* if the app was launched in foreground
*/
// temp fix for JDK 21: Constructors call overridable methods; making them final would break the
// public API.
@SuppressWarnings("this-escape")
@ApiStatus.Internal
public class AppStartMetrics extends ActivityLifecycleCallbacksAdapter {
public interface HeadlessAppStartListener {
Expand Down
Loading