Repository navigation
ci(audit): Ignore advisories that do not affect sentry-cli - #3442
Merged
Merged
Conversation
Co-Authored-By: Daniel Szoke <7881302+szokeasaurusrex@users.noreply.github.com>
sentry-junior
Bot
requested review from
a team and
szokeasaurusrex
as code owners
October 20, 2026 12:39
szokeasaurusrex
approved these changes
Oct 20, 2026
Litarnus
approved these changes
Oct 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds the RUSTSEC advisories we reviewed and closed as not affecting sentry-cli to the
ignoreinput of the weeklyrustsec/audit-checkjob, so it stops re-filing issues for them. The action's built-in dedup (by issue title) isn't reliable here: #3319 was filed even though #2978 already existed.The action splits
ignoreon commas and trims whitespace, then passes each ID ascargo audit --ignore <ID>.indicatif 0.14pop()plus a key whose drop panics; we only useLruCache<String, ()>and never callpop()Cargo.lock; never compiled (cargo tree -i rustls --target allis empty, we use native-tls)ZipArchive::extract()/ stream extraction, which we don't call; our extraction writes files manually viaenclosed_name()+File::createRUSTSEC-2026-0258 (h2) is intentionally not ignored; it was fixed in #3441.
These should be re-evaluated if usage of the affected crates changes (e.g. if we start calling
zip'sextract()or enable rustls).via @szokeasaurusrex.
--
View Junior Session [Sentry]